Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issue 2599463002: media: Move VPX mem dump provider reg/unreg to same thread. (Closed)

Created:
4 years ago by Daniele Castagna
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

media: Move VPX mem dump provider reg/unreg to same thread. Merge to 56. VPX MemoryPool is refcounted and it'll be destroyed by by whatever thread holds a reference last. Currently registering the memorypool dump provider happens in the memorypool ctor while unregistering it happens in the dtor. This can cause problems since unregistering it should happen on the same thread where it was registered first. This CL moves the register/unregister of memory pool dump provider to VpxVideoDecoder that is always called from media thead. BUG=637409 Review-Url: https://codereview.chromium.org/2580223002 Cr-Commit-Position: refs/heads/master@{#439594} (cherry picked from commit 12c9d4df53fb2d12149efae6a4c25d072e839dc1) Committed: https://chromium.googlesource.com/chromium/src/+/b5c89bb0e2d8c54499727c849466a679cf59fec4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M media/filters/vpx_video_decoder.cc View 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Daniele Castagna
4 years ago (2016-12-21 17:02:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b5c89bb0e2d8c54499727c849466a679cf59fec4.

Powered by Google App Engine
This is Rietveld 408576698