Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2580223002:
media: Move VPX mem dump provider reg/unreg to same thread. (Closed)
|
Created:
4 years ago by Daniele Castagna Modified:
4 years ago CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionmedia: Move VPX mem dump provider reg/unreg to same thread.
VPX MemoryPool is refcounted and it'll be destroyed by
by whatever thread holds a reference last.
Currently registering the memorypool dump provider happens
in the memorypool ctor while unregistering it happens in the dtor.
This can cause problems since unregistering it should happen
on the same thread where it was registered first.
This CL moves the register/unregister of memory pool dump
provider to VpxVideoDecoder that is always called from media thead.
BUG=637409
Committed: https://crrev.com/12c9d4df53fb2d12149efae6a4c25d072e839dc1
Cr-Commit-Position: refs/heads/master@{#439594}
Patch Set 1 #Patch Set 2 : Move unregister to CloseDecoder. #Messages
Total messages: 18 (12 generated)
The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== media: Move VPX mem dump provider reg/unreg to same thread. VPX MemoryPool is refcounted and it'll be destroyed by by whatever thread holds a reference last. Currently registering the memorypool dump provider happens in the memorypool while unregistering it happens in the dtor. This can cause problems since unregistering it should happen on the same thread where it was registered first. This CL moves the register/unregister of memory pool dump provider to VpxVideoDecoder that is always called from media thead. BUG=637409 ========== to ========== media: Move VPX mem dump provider reg/unreg to same thread. VPX MemoryPool is refcounted and it'll be destroyed by by whatever thread holds a reference last. Currently registering the memorypool dump provider happens in the memorypool ctor while unregistering it happens in the dtor. This can cause problems since unregistering it should happen on the same thread where it was registered first. This CL moves the register/unregister of memory pool dump provider to VpxVideoDecoder that is always called from media thead. BUG=637409 ==========
dcastagna@chromium.org changed reviewers: + sandersd@chromium.org, ssid@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
Thanks for fixing. lgtm
lgtm
The CQ bit was checked by dcastagna@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482181039605170,
"parent_rev": "88b56fdd04063f1bbe6468bb01c8fc44ad09a11d", "commit_rev":
"d0464beea33ddfb1357ff9ca5c93af3d4bed97b0"}
Message was sent while issue was closed.
Description was changed from ========== media: Move VPX mem dump provider reg/unreg to same thread. VPX MemoryPool is refcounted and it'll be destroyed by by whatever thread holds a reference last. Currently registering the memorypool dump provider happens in the memorypool ctor while unregistering it happens in the dtor. This can cause problems since unregistering it should happen on the same thread where it was registered first. This CL moves the register/unregister of memory pool dump provider to VpxVideoDecoder that is always called from media thead. BUG=637409 ========== to ========== media: Move VPX mem dump provider reg/unreg to same thread. VPX MemoryPool is refcounted and it'll be destroyed by by whatever thread holds a reference last. Currently registering the memorypool dump provider happens in the memorypool ctor while unregistering it happens in the dtor. This can cause problems since unregistering it should happen on the same thread where it was registered first. This CL moves the register/unregister of memory pool dump provider to VpxVideoDecoder that is always called from media thead. BUG=637409 Review-Url: https://codereview.chromium.org/2580223002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== media: Move VPX mem dump provider reg/unreg to same thread. VPX MemoryPool is refcounted and it'll be destroyed by by whatever thread holds a reference last. Currently registering the memorypool dump provider happens in the memorypool ctor while unregistering it happens in the dtor. This can cause problems since unregistering it should happen on the same thread where it was registered first. This CL moves the register/unregister of memory pool dump provider to VpxVideoDecoder that is always called from media thead. BUG=637409 Review-Url: https://codereview.chromium.org/2580223002 ========== to ========== media: Move VPX mem dump provider reg/unreg to same thread. VPX MemoryPool is refcounted and it'll be destroyed by by whatever thread holds a reference last. Currently registering the memorypool dump provider happens in the memorypool ctor while unregistering it happens in the dtor. This can cause problems since unregistering it should happen on the same thread where it was registered first. This CL moves the register/unregister of memory pool dump provider to VpxVideoDecoder that is always called from media thead. BUG=637409 Committed: https://crrev.com/12c9d4df53fb2d12149efae6a4c25d072e839dc1 Cr-Commit-Position: refs/heads/master@{#439594} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/12c9d4df53fb2d12149efae6a4c25d072e839dc1 Cr-Commit-Position: refs/heads/master@{#439594} |
