Revert of Convert utility process out-of-process file patching to mojo

Revert of Convert utility process out-of-process file patching to mojo (patchset #15 id:420001 of https://codereview.chromium.org/2566053002/ )

Reason for revert:
broke component updater - see crbug.com/676960

Original issue's description:
> Convert utility process out-of-process file patching to mojo
>
> Define interface chrome::mojom::FilePatcher for out-of-process file
> patching. Add that interface to the utility process, and expose the
> interface to the browser process by mojo policy [1].
>
> ChromeOutOfProcessPatcher: remove PatchHost() helper class, replace
> it with a content::UtilityProcessMojoClient() and use that to start
> and stop the utility process needed for out-of-process file patches
> and to perform out-of-process file patches using mojo calls, rather
> than IPC::Send().
>
> Add a in-process browser test for the ChromeOutOfProcessPatcher (it
> had no tests http://bit.ly/2h8mafX it seems). Copy the golden files
> to random locations (input_file, patch_file) and patch them: checks
> the patched output_file matches the golden output file.
>
> Delete all the IPC related to out-of-process file patching since we
> no longer use them, we use chrome::mojom::FilePatcher instead.
>
> [1] chrome_content_utility_manifest_overlay.json
>
> TBR=waffles@chromium.org
> BUG=597124, 660325
>
> Committed: https://crrev.com/32afc44b332255130c247e3bfc4a27261d11ddfb
> Cr-Commit-Position: refs/heads/master@{#440601}

TBR=jochen@chromium.org,dcheng@chromium.org,sammc@chromium.org,tibell@chromium.org,waffles@chromium.org,sorin@chromium.org,noel@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=597124, 660325, 676960
Committed: https://crrev.com/53919401199f8cc8c0e5042dd9c0fc9716825a1c
Cr-Commit-Position: refs/heads/master@{#440686}

[Will Harris, 2016-12-25 20:25:08]

The CQ bit was checked by wfh@chromium.org

[Will Harris, 2016-12-25 20:25:08]

Created Revert of Convert utility process out-of-process file patching to mojo

[commit-bot: I haz the power, 2016-12-25 20:25:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Will Harris, 2016-12-25 20:25:20]

Description was changed from

==========
Revert of Convert utility process out-of-process file patching to mojo (patchset
#15 id:420001 of https://codereview.chromium.org/2566053002/ )

Reason for revert:
broke component updater - see crbug.com/676960

Original issue's description:
> Convert utility process out-of-process file patching to mojo
> 
> Define interface chrome::mojom::FilePatcher for out-of-process file
> patching. Add that interface to the utility process, and expose the
> interface to the browser process by mojo policy [1].
> 
> ChromeOutOfProcessPatcher: remove PatchHost() helper class, replace
> it with a content::UtilityProcessMojoClient() and use that to start
> and stop the utility process needed for out-of-process file patches
> and to perform out-of-process file patches using mojo calls, rather
> than IPC::Send().
> 
> Add a in-process browser test for the ChromeOutOfProcessPatcher (it
> had no tests http://bit.ly/2h8mafX it seems). Copy the golden files
> to random locations (input_file, patch_file) and patch them: checks
> the patched output_file matches the golden output file.
> 
> Delete all the IPC related to out-of-process file patching since we
> no longer use them, we use chrome::mojom::FilePatcher instead.
> 
> [1] chrome_content_utility_manifest_overlay.json
> 
> TBR=waffles@chromium.org
> BUG=597124, 660325
> 
> Committed: https://crrev.com/32afc44b332255130c247e3bfc4a27261d11ddfb
> Cr-Commit-Position: refs/heads/master@{#440601}

TBR=jochen@chromium.org,dcheng@chromium.org,sammc@chromium.org,tibell@chromiu...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=597124, 660325
==========

to

==========
Revert of Convert utility process out-of-process file patching to mojo (patchset
#15 id:420001 of https://codereview.chromium.org/2566053002/ )

Reason for revert:
broke component updater - see crbug.com/676960

Original issue's description:
> Convert utility process out-of-process file patching to mojo
> 
> Define interface chrome::mojom::FilePatcher for out-of-process file
> patching. Add that interface to the utility process, and expose the
> interface to the browser process by mojo policy [1].
> 
> ChromeOutOfProcessPatcher: remove PatchHost() helper class, replace
> it with a content::UtilityProcessMojoClient() and use that to start
> and stop the utility process needed for out-of-process file patches
> and to perform out-of-process file patches using mojo calls, rather
> than IPC::Send().
> 
> Add a in-process browser test for the ChromeOutOfProcessPatcher (it
> had no tests http://bit.ly/2h8mafX it seems). Copy the golden files
> to random locations (input_file, patch_file) and patch them: checks
> the patched output_file matches the golden output file.
> 
> Delete all the IPC related to out-of-process file patching since we
> no longer use them, we use chrome::mojom::FilePatcher instead.
> 
> [1] chrome_content_utility_manifest_overlay.json
> 
> TBR=waffles@chromium.org
> BUG=597124, 660325
> 
> Committed: https://crrev.com/32afc44b332255130c247e3bfc4a27261d11ddfb
> Cr-Commit-Position: refs/heads/master@{#440601}

TBR=jochen@chromium.org,dcheng@chromium.org,sammc@chromium.org,tibell@chromiu...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=597124, 660325,676960
==========

[commit-bot: I haz the power, 2016-12-25 21:30:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482697508222650, "parent_rev":
"46507cf48cb5e70417a3f68a76d85b6eec5895c9", "commit_rev":
"ab32d734ce027e4892d1cd4cfe524465cabcc097"}

[commit-bot: I haz the power, 2016-12-25 21:31:03]

Description was changed from

==========
Revert of Convert utility process out-of-process file patching to mojo (patchset
#15 id:420001 of https://codereview.chromium.org/2566053002/ )

Reason for revert:
broke component updater - see crbug.com/676960

Original issue's description:
> Convert utility process out-of-process file patching to mojo
> 
> Define interface chrome::mojom::FilePatcher for out-of-process file
> patching. Add that interface to the utility process, and expose the
> interface to the browser process by mojo policy [1].
> 
> ChromeOutOfProcessPatcher: remove PatchHost() helper class, replace
> it with a content::UtilityProcessMojoClient() and use that to start
> and stop the utility process needed for out-of-process file patches
> and to perform out-of-process file patches using mojo calls, rather
> than IPC::Send().
> 
> Add a in-process browser test for the ChromeOutOfProcessPatcher (it
> had no tests http://bit.ly/2h8mafX it seems). Copy the golden files
> to random locations (input_file, patch_file) and patch them: checks
> the patched output_file matches the golden output file.
> 
> Delete all the IPC related to out-of-process file patching since we
> no longer use them, we use chrome::mojom::FilePatcher instead.
> 
> [1] chrome_content_utility_manifest_overlay.json
> 
> TBR=waffles@chromium.org
> BUG=597124, 660325
> 
> Committed: https://crrev.com/32afc44b332255130c247e3bfc4a27261d11ddfb
> Cr-Commit-Position: refs/heads/master@{#440601}

TBR=jochen@chromium.org,dcheng@chromium.org,sammc@chromium.org,tibell@chromiu...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=597124, 660325,676960
==========

to

==========
Revert of Convert utility process out-of-process file patching to mojo (patchset
#15 id:420001 of https://codereview.chromium.org/2566053002/ )

Reason for revert:
broke component updater - see crbug.com/676960

Original issue's description:
> Convert utility process out-of-process file patching to mojo
> 
> Define interface chrome::mojom::FilePatcher for out-of-process file
> patching. Add that interface to the utility process, and expose the
> interface to the browser process by mojo policy [1].
> 
> ChromeOutOfProcessPatcher: remove PatchHost() helper class, replace
> it with a content::UtilityProcessMojoClient() and use that to start
> and stop the utility process needed for out-of-process file patches
> and to perform out-of-process file patches using mojo calls, rather
> than IPC::Send().
> 
> Add a in-process browser test for the ChromeOutOfProcessPatcher (it
> had no tests http://bit.ly/2h8mafX it seems). Copy the golden files
> to random locations (input_file, patch_file) and patch them: checks
> the patched output_file matches the golden output file.
> 
> Delete all the IPC related to out-of-process file patching since we
> no longer use them, we use chrome::mojom::FilePatcher instead.
> 
> [1] chrome_content_utility_manifest_overlay.json
> 
> TBR=waffles@chromium.org
> BUG=597124, 660325
> 
> Committed: https://crrev.com/32afc44b332255130c247e3bfc4a27261d11ddfb
> Cr-Commit-Position: refs/heads/master@{#440601}

TBR=jochen@chromium.org,dcheng@chromium.org,sammc@chromium.org,tibell@chromiu...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=597124, 660325,676960

Review-Url: https://codereview.chromium.org/2599393002
==========

[commit-bot: I haz the power, 2016-12-25 21:31:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-25 21:33:45]

Description was changed from

==========
Revert of Convert utility process out-of-process file patching to mojo (patchset
#15 id:420001 of https://codereview.chromium.org/2566053002/ )

Reason for revert:
broke component updater - see crbug.com/676960

Original issue's description:
> Convert utility process out-of-process file patching to mojo
> 
> Define interface chrome::mojom::FilePatcher for out-of-process file
> patching. Add that interface to the utility process, and expose the
> interface to the browser process by mojo policy [1].
> 
> ChromeOutOfProcessPatcher: remove PatchHost() helper class, replace
> it with a content::UtilityProcessMojoClient() and use that to start
> and stop the utility process needed for out-of-process file patches
> and to perform out-of-process file patches using mojo calls, rather
> than IPC::Send().
> 
> Add a in-process browser test for the ChromeOutOfProcessPatcher (it
> had no tests http://bit.ly/2h8mafX it seems). Copy the golden files
> to random locations (input_file, patch_file) and patch them: checks
> the patched output_file matches the golden output file.
> 
> Delete all the IPC related to out-of-process file patching since we
> no longer use them, we use chrome::mojom::FilePatcher instead.
> 
> [1] chrome_content_utility_manifest_overlay.json
> 
> TBR=waffles@chromium.org
> BUG=597124, 660325
> 
> Committed: https://crrev.com/32afc44b332255130c247e3bfc4a27261d11ddfb
> Cr-Commit-Position: refs/heads/master@{#440601}

TBR=jochen@chromium.org,dcheng@chromium.org,sammc@chromium.org,tibell@chromiu...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=597124, 660325,676960

Review-Url: https://codereview.chromium.org/2599393002
==========

to

==========
Revert of Convert utility process out-of-process file patching to mojo (patchset
#15 id:420001 of https://codereview.chromium.org/2566053002/ )

Reason for revert:
broke component updater - see crbug.com/676960

Original issue's description:
> Convert utility process out-of-process file patching to mojo
>
> Define interface chrome::mojom::FilePatcher for out-of-process file
> patching. Add that interface to the utility process, and expose the
> interface to the browser process by mojo policy [1].
>
> ChromeOutOfProcessPatcher: remove PatchHost() helper class, replace
> it with a content::UtilityProcessMojoClient() and use that to start
> and stop the utility process needed for out-of-process file patches
> and to perform out-of-process file patches using mojo calls, rather
> than IPC::Send().
>
> Add a in-process browser test for the ChromeOutOfProcessPatcher (it
> had no tests http://bit.ly/2h8mafX it seems). Copy the golden files
> to random locations (input_file, patch_file) and patch them: checks
> the patched output_file matches the golden output file.
>
> Delete all the IPC related to out-of-process file patching since we
> no longer use them, we use chrome::mojom::FilePatcher instead.
>
> [1] chrome_content_utility_manifest_overlay.json
>
> TBR=waffles@chromium.org
> BUG=597124, 660325
>
> Committed: https://crrev.com/32afc44b332255130c247e3bfc4a27261d11ddfb
> Cr-Commit-Position: refs/heads/master@{#440601}

TBR=jochen@chromium.org,dcheng@chromium.org,sammc@chromium.org,tibell@chromiu...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=597124, 660325,676960

Committed: https://crrev.com/53919401199f8cc8c0e5042dd9c0fc9716825a1c
Cr-Commit-Position: refs/heads/master@{#440686}
==========

[commit-bot: I haz the power, 2016-12-25 21:33:46]

Patchset 1 (id:??) landed as
https://crrev.com/53919401199f8cc8c0e5042dd9c0fc9716825a1c
Cr-Commit-Position: refs/heads/master@{#440686}

[dcheng, 2016-12-26 22:19:16]

lgtm

[waffles, 2016-12-27 14:32:00]

lgtm

thanks so much for taking care of this, Will