Create headerHeightForTab in TabHeadersDelegate.

ios/chrome/browser/ui/fullscreen_controller.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_CHROME_BROWSER_UI_FULLSCREEN_CONTROLLER_H_
 #define IOS_CHROME_BROWSER_UI_FULLSCREEN_CONTROLLER_H_
 
 #import <UIKit/UIKit.h>
 
 #import "ios/web/public/web_state/crw_web_controller_observer.h"
 #import "ios/web/public/web_state/crw_web_view_scroll_view_proxy.h"
 
 namespace ios_internal {
 // Duration of the toolbar animation.
 const NSTimeInterval kToolbarAnimationDuration = 0.3;
 }  // namespace ios_internal
 
 @class CRWWebViewScrollViewProxy;
 @class FullScreenController;
+@class Tab;
 
 namespace web {
 class NavigationManager;
 }
 
 // Notification when the application is set up for testing.
 extern NSString* const kSetupForTestingWillCloseAllTabsNotification;
 
 @protocol FullScreenControllerDelegate<NSObject>
 
@@ skipping 12 matching lines @@
 // webViewProxy's scroll view at the same time. Should always be animated.
 // Only happens during a call to -setHeaderHeight:visible:onScrollView:. If
 // |changeTopContentPadding| is YES, then in addition to scrolling, delegate
 // should also update webViewProxy's topContentPadding.
 - (void)fullScreenController:(FullScreenController*)fullScreenController
     drawHeaderViewFromOffset:(CGFloat)headerOffset
               onWebViewProxy:(id<CRWWebViewProxy>)webViewProxy
      changeTopContentPadding:(BOOL)changeTopContentPadding
            scrollingToOffset:(CGFloat)contentOffset;
 
-// Called to retrieve the current height of the header. Only called from
+// Called to retrieve the height of the header view for the tab model's current
+// tab. Only called from -setHeaderVisible:, so that method needs to be
+// explicitly called when the height changes.
+- (CGFloat)headerHeightForCurrentTab;
+
+// Called to retrieve the height of the header view for |tab|. Only called from
 // -setHeaderVisible:, so that method needs to be explicitly called when the
 // height changes.
-- (CGFloat)headerHeight;
+- (CGFloat)headerHeightForTab:(Tab*)tab;

[noyau (Ping after 24h), 2017/01/09 15:09:31]

This method should not be in this protocol, it is never called by the fullscreen
controller, and the full screen controller should not know anything whatsoever
about Tab.

[Olivier, 2017/01/09 17:23:18]

Right. The delegate was called from other places.
I create a specific delegate to handle headers.

 
 // Tests if the session ID matches the current tab.
 - (BOOL)isTabWithIDCurrent:(NSString*)sessionID;
 
 // Current offset of the header. A value between 0.0 (fully visible) and
 // headerHeight (fully hidden).
 - (CGFloat)currentHeaderOffset;
 
 @end
 
@@ skipping 52 matching lines @@
 @interface FullScreenController (UsedForTesting)
 // Enables/Disables the FullScreenController in tests. The unit tests do not set
 // the delegate which is crucial for methods to work on the controller.
 // This a temporary solution.
 // TODO(shreyasv): Find a better solution/remove this when FullScreenController
 // moves to Tab.
 + (void)setEnabledForTests:(BOOL)enabled;
 @end
 
 #endif  // IOS_CHROME_BROWSER_UI_FULLSCREEN_CONTROLLER_H_