Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2599283002: Reland "[heap] Ensure progress when incrementally marking wrappers" (Closed)

Created:
3 years, 12 months ago by Michael Lippautz
Modified:
3 years, 12 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[heap] Ensure progress when incrementally marking wrappers" 1) Alternate between processing v8 and wrappers 2) Once v8 is empty, try 3 rounds of finding the fixpoint between v8 and wrappers 3) After that, finalize once v8 marking deque is empty again Reland fixed: Toggle needs to be IncrementalMarking global as we need to properly alternate tracing v8 and wrappers. BUG=chromium:468240, chromium:668164 Review-Url: https://codereview.chromium.org/2599283002 Cr-Commit-Position: refs/heads/master@{#41940} Committed: https://chromium.googlesource.com/v8/v8/+/fb8b3bcc821cf11c22593d2773c5f06823acd53f

Patch Set 1 : Broken #

Patch Set 2 : Fix: Make toggle a IM global to avoid only advancing wrappers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -47 lines) Patch
M src/heap/embedder-tracing.h View 3 chunks +12 lines, -1 line 0 comments Download
M src/heap/embedder-tracing.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +11 lines, -9 lines 0 comments Download
M src/heap/incremental-marking.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 3 chunks +36 lines, -32 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
Michael Lippautz
ptal manually verified webkit-unit-tests don't break
3 years, 12 months ago (2016-12-23 10:20:47 UTC) #6
Hannes Payer (out of office)
lgtm
3 years, 12 months ago (2016-12-23 12:08:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599283002/20001
3 years, 12 months ago (2016-12-23 12:24:00 UTC) #11
commit-bot: I haz the power
3 years, 12 months ago (2016-12-23 12:25:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/fb8b3bcc821cf11c22593d2773c5f06823a...

Powered by Google App Engine
This is Rietveld 408576698