Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2599203003: gpu: Maintain the deferred log messages separately from the IPC messages. (Closed)

Created:
4 years ago by sadrul
Modified:
3 years, 11 months ago
Reviewers:
jbauman
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Maintain the deferred log messages separately from the IPC messages. Instead of keeping a queue of IPC messages in GpuChildThread for the deferred log messages that are sent to the browser, maintain a queue of structs describing the log messages. This makes it easier to follow the code, and easier to replace the chrome IPC with mojo IPC in subsequent patches. BUG=643746 Committed: https://crrev.com/db04bc3039a04e5a26c13cfe63818b3f170f01cf Cr-Commit-Position: refs/heads/master@{#441318}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M content/gpu/gpu_child_thread.h View 1 chunk +6 lines, -1 line 0 comments Download
M content/gpu/gpu_child_thread.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
sadrul
4 years ago (2016-12-23 06:03:53 UTC) #3
sadrul
4 years ago (2016-12-23 06:04:16 UTC) #5
jbauman
lgtm
3 years, 11 months ago (2017-01-03 22:44:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599203003/1
3 years, 11 months ago (2017-01-04 03:50:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 04:51:21 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 04:54:21 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db04bc3039a04e5a26c13cfe63818b3f170f01cf
Cr-Commit-Position: refs/heads/master@{#441318}

Powered by Google App Engine
This is Rietveld 408576698