Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2599153002:
Remove base::ScopedPtrHashMap from apps/. (Closed)
|
Created:
4 years ago by Avi (use Gerrit) Modified:
3 years, 11 months ago Reviewers:
benwells CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove base::ScopedPtrHashMap from apps/.
BUG=579229
Committed: https://crrev.com/ced8fb1ce514f8a02932b5cc7de0bfe53ec248da
Cr-Commit-Position: refs/heads/master@{#440809}
Patch Set 1 #Patch Set 2 : fix #Messages
Total messages: 18 (13 generated)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
avi@chromium.org changed reviewers: + benwells@chromium.org
lgtm
The CQ bit was checked by avi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482880382162440,
"parent_rev": "74075490926cba197ad1652ddeccad83c85f6869", "commit_rev":
"9e037e5a572302d7c36d71a94956728db25a32c8"}
Message was sent while issue was closed.
Description was changed from ========== Remove base::ScopedPtrHashMap from apps/. BUG=579229 ========== to ========== Remove base::ScopedPtrHashMap from apps/. BUG=579229 Review-Url: https://codereview.chromium.org/2599153002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove base::ScopedPtrHashMap from apps/. BUG=579229 Review-Url: https://codereview.chromium.org/2599153002 ========== to ========== Remove base::ScopedPtrHashMap from apps/. BUG=579229 Committed: https://crrev.com/ced8fb1ce514f8a02932b5cc7de0bfe53ec248da Cr-Commit-Position: refs/heads/master@{#440809} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ced8fb1ce514f8a02932b5cc7de0bfe53ec248da Cr-Commit-Position: refs/heads/master@{#440809} |
