Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2599143003: Add a new QUIC platform API quic_aligned.h for the alignment macro definitions. (Closed)

Created:
3 years, 12 months ago by Ryan Hamilton
Modified:
3 years, 11 months ago
Reviewers:
Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a new QUIC platform API quic_aligned.h for the alignment macro definitions. Merge internal change: 142807099 Committed: https://crrev.com/21b0c2fa9500fd7953fff1fa8041da40afc81692 Cr-Commit-Position: refs/heads/master@{#440725}

Patch Set 1 #

Patch Set 2 : license #

Patch Set 3 : impl #

Patch Set 4 : windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -20 lines) Patch
M net/net.gypi View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/core/crypto/aead_base_encrypter.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_arena_scoped_ptr.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_framer.cc View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M net/quic/core/quic_packet_creator.cc View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
M net/quic/core/quic_types.h View 1 chunk +0 lines, -10 lines 0 comments Download
A net/quic/platform/api/quic_aligned.h View 1 1 chunk +14 lines, -0 lines 0 comments Download
A net/quic/platform/impl/quic_aligned_impl.h View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
Ryan Hamilton
3 years, 12 months ago (2016-12-24 15:45:28 UTC) #4
Jana
lgtm Nice! Is there an equivalent internal CL?
3 years, 12 months ago (2016-12-26 02:00:06 UTC) #15
Ryan Hamilton
On 2016/12/26 02:00:06, Jana wrote: > lgtm > > Nice! Is there an equivalent internal ...
3 years, 12 months ago (2016-12-26 21:53:09 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599143003/60001
3 years, 12 months ago (2016-12-26 21:53:22 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
3 years, 12 months ago (2016-12-26 23:06:55 UTC) #21
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:45:21 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/21b0c2fa9500fd7953fff1fa8041da40afc81692
Cr-Commit-Position: refs/heads/master@{#440725}

Powered by Google App Engine
This is Rietveld 408576698