Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2598993002: [tools] Use better category names in callstats.html (Closed)

Created:
4 years ago by Camillo Bruni
Modified:
4 years ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Use better category names in callstats.html This CL changes the displayed names of "Callbacks" and "Runtime" to "Blink C++" and "V8 C++" respectively. NOTRY=true Review-Url: https://codereview.chromium.org/2598993002 Cr-Commit-Position: refs/heads/master@{#41920} Committed: https://chromium.googlesource.com/v8/v8/+/b9b6e0b06d8ccd6759b32dadad8ed4bda1258aec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/callstats.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Camillo Bruni
PTAL
4 years ago (2016-12-22 12:13:42 UTC) #4
Michael Hablich
On 2016/12/22 12:13:42, Camillo Bruni wrote: > PTAL hooray, lgtm. This will not show up ...
4 years ago (2016-12-22 13:28:45 UTC) #5
Camillo Bruni
On 2016/12/22 at 13:28:45, hablich wrote: > On 2016/12/22 12:13:42, Camillo Bruni wrote: > > ...
4 years ago (2016-12-22 14:07:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598993002/1
4 years ago (2016-12-22 14:07:18 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-22 14:09:02 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b9b6e0b06d8ccd6759b32dadad8ed4bda12...

Powered by Google App Engine
This is Rietveld 408576698