Use explicit WebString <-> string{16,} conversion methods for WebURLLoader files

Use explicit WebString string conversion methods for WebURLLoader files

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

Also for some of the strings are guaranteed to be ASCII-only
replace WebString::fromUTF8 with WebString::fromASCII

BUG=667131
Committed: https://crrev.com/5204fb6a7ff224c2f1f4f7f8f086b215d50b10f7
Cr-Commit-Position: refs/heads/master@{#440712}

[kinuko, 2016-12-22 06:40:08]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 06:40:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2016-12-22 06:41:52]

Description was changed from

==========
Use explicit WebString string conversion methods for WebURLLoader files

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

Also for some of the strings are guaranteed to be ASCII-only
replace WebString::fromUTF8 with WebString::fromASCII

BUG=667131
==========

to

==========
Use explicit WebString string conversion methods for WebURLLoader files

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

Also for some of the strings are guaranteed to be ASCII-only
replace WebString::fromUTF8 with WebString::fromASCII

BUG=667131
==========

[kinuko, 2016-12-22 06:41:52]

kinuko@chromium.org changed reviewers:
+ yhirano@chromium.org

[kinuko, 2016-12-22 06:42:03]

PTL

[commit-bot: I haz the power, 2016-12-22 07:55:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 07:55:03]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-12-26 03:36:22]

lgtm

https://codereview.chromium.org/2598923003/diff/1/content/child/web_url_loade...
File content/child/web_url_loader_impl.cc (right):

https://codereview.chromium.org/2598923003/diff/1/content/child/web_url_loade...
content/child/web_url_loader_impl.cc:545:
request.httpHeaderField(WebString::fromASCII("Referer")).latin1());
WebString::fromASCII(c_str).latin1() looks identical to std::string(c_str),
right?

[kinuko, 2016-12-26 07:28:05]

Thanks!

https://codereview.chromium.org/2598923003/diff/1/content/child/web_url_loade...
File content/child/web_url_loader_impl.cc (right):

https://codereview.chromium.org/2598923003/diff/1/content/child/web_url_loade...
content/child/web_url_loader_impl.cc:545:
request.httpHeaderField(WebString::fromASCII("Referer")).latin1());
On 2016/12/26 03:36:22, yhirano wrote:
> WebString::fromASCII(c_str).latin1() looks identical to std::string(c_str),
> right?

This gets the latin1 of request.httpHeaderField(), so not really.

[yhirano, 2016-12-26 07:38:59]

https://codereview.chromium.org/2598923003/diff/1/content/child/web_url_loade...
File content/child/web_url_loader_impl.cc (right):

https://codereview.chromium.org/2598923003/diff/1/content/child/web_url_loade...
content/child/web_url_loader_impl.cc:545:
request.httpHeaderField(WebString::fromASCII("Referer")).latin1());
On 2016/12/26 07:28:05, kinuko wrote:
> On 2016/12/26 03:36:22, yhirano wrote:
> > WebString::fromASCII(c_str).latin1() looks identical to std::string(c_str),
> > right?
> 
> This gets the latin1 of request.httpHeaderField(), so not really.

Ah, I see. Thanks.

[kinuko, 2016-12-26 13:09:08]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2016-12-26 13:09:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-26 13:57:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482757748957650, "parent_rev":
"edc69c100d3393975fb0e95ebb0e8cb743c6c227", "commit_rev":
"32e54def8765f9770648a8a0fe297019424e6a12"}

[commit-bot: I haz the power, 2016-12-26 13:58:07]

Description was changed from

==========
Use explicit WebString string conversion methods for WebURLLoader files

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

Also for some of the strings are guaranteed to be ASCII-only
replace WebString::fromUTF8 with WebString::fromASCII

BUG=667131
==========

to

==========
Use explicit WebString string conversion methods for WebURLLoader files

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

Also for some of the strings are guaranteed to be ASCII-only
replace WebString::fromUTF8 with WebString::fromASCII

BUG=667131

Review-Url: https://codereview.chromium.org/2598923003
==========

[commit-bot: I haz the power, 2016-12-26 13:58:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-26 14:00:30]

Description was changed from

==========
Use explicit WebString string conversion methods for WebURLLoader files

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

Also for some of the strings are guaranteed to be ASCII-only
replace WebString::fromUTF8 with WebString::fromASCII

BUG=667131

Review-Url: https://codereview.chromium.org/2598923003
==========

to

==========
Use explicit WebString string conversion methods for WebURLLoader files

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

Also for some of the strings are guaranteed to be ASCII-only
replace WebString::fromUTF8 with WebString::fromASCII

BUG=667131

Committed: https://crrev.com/5204fb6a7ff224c2f1f4f7f8f086b215d50b10f7
Cr-Commit-Position: refs/heads/master@{#440712}
==========

[commit-bot: I haz the power, 2016-12-26 14:00:31]

Patchset 1 (id:??) landed as
https://crrev.com/5204fb6a7ff224c2f1f4f7f8f086b215d50b10f7
Cr-Commit-Position: refs/heads/master@{#440712}