Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2598873002: DevTools: Make sure network and main flamechart scales are in sync. (Closed)

Created:
4 years ago by alph
Modified:
3 years, 12 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Make sure network and main flamechart scales are in sync. BUG=676524 Committed: https://crrev.com/4d12661897f22c6c23203918a832336b74c5542b Cr-Commit-Position: refs/heads/master@{#440512}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressing comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js View 1 3 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/flameChart.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
alph
4 years ago (2016-12-22 01:28:52 UTC) #2
pfeldman
lgtm % comment https://codereview.chromium.org/2598873002/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js File third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js (right): https://codereview.chromium.org/2598873002/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js#newcode36 third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js:36: alwaysShowVerticalScroll(enable) { It does not sound ...
3 years, 12 months ago (2016-12-22 17:41:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598873002/20001
3 years, 12 months ago (2016-12-22 19:42:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 12 months ago (2016-12-22 21:44:25 UTC) #9
commit-bot: I haz the power
3 years, 12 months ago (2016-12-22 21:48:12 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4d12661897f22c6c23203918a832336b74c5542b
Cr-Commit-Position: refs/heads/master@{#440512}

Powered by Google App Engine
This is Rietveld 408576698