Add SkColorSpace to gfx::ColorSpace

Add SkColorSpace to gfx::ColorSpace

This allows more consistent and efficient conversion between the
two types.

Because we're including the header for SkColorSpace, targets that
include this can't play fast and loose with dependencies. Break off
the color space dependencies as //ui/gfx:color_space, and include
it in the media and remoting BUILD.gn that need it.

BUG=634102
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/87b65e9b67790efd6aaa2201bbee4485f9015dca
Cr-Commit-Position: refs/heads/master@{#440747}

[ccameron, 2016-12-22 00:37:18]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 00:37:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 00:57:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 00:57:32]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ccameron, 2016-12-22 21:32:15]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 21:32:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 21:37:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 21:37:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ccameron, 2016-12-22 21:44:34]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 21:44:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 21:48:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 21:48:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ccameron, 2016-12-22 21:52:20]

Patchset #2 (id:20001) has been deleted

[ccameron, 2016-12-22 21:52:28]

Patchset #2 (id:40001) has been deleted

[ccameron, 2016-12-22 21:52:34]

Patchset #2 (id:60001) has been deleted

[ccameron, 2016-12-22 21:53:54]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 21:54:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 21:57:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 21:57:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[ccameron, 2016-12-22 22:15:16]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 22:15:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-12-22 22:27:58]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 22:28:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-12-22 22:30:39]

Description was changed from

==========
Add SkColorSpace to gfx::ColorSpace

BUG=
==========

to

==========
Add SkColorSpace to gfx::ColorSpace

This allows more consistent and efficient conversion between the
two types.

Because we're including the header for SkColorSpace, targets that
include this can't play fast and loose with dependencies. Break off
the color space dependencies as //ui/gfx:color_space, and include
it in the media and remoting BUILD.gn that need it.

BUG=634102
==========

[watk, 2016-12-22 22:45:14]

watk@chromium.org changed reviewers:
+ watk@chromium.org

[watk, 2016-12-22 22:45:15]

lgtm

[kelvinp, 2016-12-22 22:49:15]

kelvinp@chromium.org changed reviewers:
+ sergeyu@chromium.org

[commit-bot: I haz the power, 2016-12-22 22:51:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 22:51:26]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[ccameron, 2016-12-22 23:10:09]

Thanks!

adding sergeyu@ for remoting/

[Sergey Ulanov, 2016-12-23 00:53:29]

lgtm

[ccameron, 2016-12-27 07:58:39]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-12-27 07:58:39]

The patchset sent to the CQ was uploaded after l-g-t-m from watk@chromium.org
Link to the patchset: https://codereview.chromium.org/2598833002/#ps140001
(title: "Add android targets")

[ccameron, 2016-12-27 07:58:41]

The CQ bit was unchecked by ccameron@chromium.org

[ccameron, 2016-12-27 07:58:52]

Description was changed from

==========
Add SkColorSpace to gfx::ColorSpace

This allows more consistent and efficient conversion between the
two types.

Because we're including the header for SkColorSpace, targets that
include this can't play fast and loose with dependencies. Break off
the color space dependencies as //ui/gfx:color_space, and include
it in the media and remoting BUILD.gn that need it.

BUG=634102
==========

to

==========
Add SkColorSpace to gfx::ColorSpace

This allows more consistent and efficient conversion between the
two types.

Because we're including the header for SkColorSpace, targets that
include this can't play fast and loose with dependencies. Break off
the color space dependencies as //ui/gfx:color_space, and include
it in the media and remoting BUILD.gn that need it.

BUG=634102
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2016-12-27 07:58:54]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-12-27 07:58:55]

The patchset sent to the CQ was uploaded after l-g-t-m from watk@chromium.org,
sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2598833002/#ps160001
(title: "Add tests")

[commit-bot: I haz the power, 2016-12-27 07:59:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 10:19:10]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1482825534848020,
"parent_rev": "0360c2f1c0582114e876a4f9367d1fd7344af9a3", "commit_rev":
"efd8a3bfce77976c43ba830a8e16746315f4d2f2"}

[commit-bot: I haz the power, 2016-12-27 10:19:44]

Description was changed from

==========
Add SkColorSpace to gfx::ColorSpace

This allows more consistent and efficient conversion between the
two types.

Because we're including the header for SkColorSpace, targets that
include this can't play fast and loose with dependencies. Break off
the color space dependencies as //ui/gfx:color_space, and include
it in the media and remoting BUILD.gn that need it.

BUG=634102
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Add SkColorSpace to gfx::ColorSpace

This allows more consistent and efficient conversion between the
two types.

Because we're including the header for SkColorSpace, targets that
include this can't play fast and loose with dependencies. Break off
the color space dependencies as //ui/gfx:color_space, and include
it in the media and remoting BUILD.gn that need it.

BUG=634102
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2598833002
==========

[commit-bot: I haz the power, 2016-12-27 10:19:45]

Committed patchset #6 (id:160001)

[commit-bot: I haz the power, 2017-01-02 15:45:59]

Description was changed from

==========
Add SkColorSpace to gfx::ColorSpace

This allows more consistent and efficient conversion between the
two types.

Because we're including the header for SkColorSpace, targets that
include this can't play fast and loose with dependencies. Break off
the color space dependencies as //ui/gfx:color_space, and include
it in the media and remoting BUILD.gn that need it.

BUG=634102
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2598833002
==========

to

==========
Add SkColorSpace to gfx::ColorSpace

This allows more consistent and efficient conversion between the
two types.

Because we're including the header for SkColorSpace, targets that
include this can't play fast and loose with dependencies. Break off
the color space dependencies as //ui/gfx:color_space, and include
it in the media and remoting BUILD.gn that need it.

BUG=634102
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/87b65e9b67790efd6aaa2201bbee4485f9015dca
Cr-Commit-Position: refs/heads/master@{#440747}
==========

[commit-bot: I haz the power, 2017-01-02 15:46:00]

Patchset 6 (id:??) landed as
https://crrev.com/87b65e9b67790efd6aaa2201bbee4485f9015dca
Cr-Commit-Position: refs/heads/master@{#440747}