Issue 25988002: Revert 226920 "Roll Clang 188423:191856."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25988002: Revert 226920 "Roll Clang 188423:191856." (Closed)

Created:
7 years, 2 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 1 month ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 226920 "Roll Clang 188423:191856." I suspect this caused a 25% sizes regression on Mac: http://build.chromium.org/f/chromium/perf/mac-release/sizes/report.html?history=150&rev=-1&graph=Chromium.app > Roll Clang 188423:191856. > > Remove libprofile_rt from package.sh, it doesn't exist after LLVM r191835 > > BUG=290204, 303886 > R=thakis@chromium.org > TBR=net owner > NOTRY=true > > Review URL: https://codereview.chromium.org/25875004 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226978

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -27 lines)			Patch
M	trunk/src/base/debug/stack_trace_android.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	trunk/src/base/security_unittest.cc	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	trunk/src/build/common.gypi	View	3 chunks	+0 lines, -16 lines	0 comments	Download
M	trunk/src/net/cert/multi_threaded_cert_verifier_unittest.cc	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	trunk/src/tools/clang/scripts/package.sh	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/tools/clang/scripts/update.sh	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

jochen (gone - plz use gerrit)

Committed patchset #1 manually as r226978.

7 years, 2 months ago (2013-10-04 09:10:32 UTC) #2

carlosreynosog

7 years, 1 month ago (2013-11-05 06:52:46 UTC) #3

Message was sent while issue was closed.

On 2013/10/04 09:10:32, jochen wrote:
> Committed patchset #1 manually as r226978.