Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2598793002: wayland-protocols: Add pointer_stylus_exists error to zcr_stylus_v1 interface. (Closed)

Created:
4 years ago by denniskempin
Modified:
4 years ago
Reviewers:
skau, yhanada
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

wayland-protocols: Add pointer_stylus_exists error to zcr_stylus_v1 interface. This error is produced if get_pointer_stylus method is called with a pointer object that is already associated with a pointer stylus object. BUG=673666, 665499 NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2575693002 Cr-Commit-Position: refs/heads/master@{#438985} (cherry picked from commit 17d98b2b1613084add2159bda3002d32611293a5) Review-Url: https://codereview.chromium.org/2598793002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -5 lines) Patch
M third_party/wayland-protocols/include/protocol/stylus-unstable-v1-client-protocol.h View 2 chunks +12 lines, -1 line 0 comments Download
M third_party/wayland-protocols/include/protocol/stylus-unstable-v1-server-protocol.h View 2 chunks +13 lines, -1 line 0 comments Download
M third_party/wayland-protocols/protocol/stylus-protocol.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/wayland-protocols/unstable/stylus/stylus-unstable-v1.xml View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
denniskempin
4 years ago (2016-12-21 21:10:15 UTC) #2
denniskempin
4 years ago (2016-12-21 21:10:30 UTC) #4
skau
lgtm Merge approval obtained through crbug.com/665499 this CL is a prerequisite to that bug.
4 years ago (2016-12-21 21:14:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598793002/1
4 years ago (2016-12-21 21:15:33 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-21 21:19:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698