Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2598733002: Fix handling of store-write failures in Pver4 (Closed)

Created:
4 years ago by Nathan Parker
Modified:
4 years ago
Reviewers:
jialiul, Jialiu Lin
CC:
chromium-reviews, vakh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix handling of store-write failures in Pver4 BUG=676374 Committed: https://crrev.com/6f5e7edad22456cd98800c77bc221729869f1f68 Cr-Commit-Position: refs/heads/master@{#440254}

Patch Set 1 #

Patch Set 2 : Change the way I generate a non-writable file, for Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M components/safe_browsing_db/v4_store.cc View 1 chunk +4 lines, -1 line 0 comments Download
M components/safe_browsing_db/v4_store_unittest.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
Nathan Parker
A small change to error handling, discovered in my manual testing.
4 years ago (2016-12-21 22:21:02 UTC) #9
Jialiu Lin
lgtm
4 years ago (2016-12-21 22:28:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598733002/20001
4 years ago (2016-12-21 22:32:19 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-21 23:00:35 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-21 23:03:58 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f5e7edad22456cd98800c77bc221729869f1f68
Cr-Commit-Position: refs/heads/master@{#440254}

Powered by Google App Engine
This is Rietveld 408576698