Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2598693002: [system health] Clean up bugs of disabled stories (Closed)

Created:
4 years ago by perezju
Modified:
4 years ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[system health] Clean up bugs of disabled stories Some of the disable bugs currently point to "catch all" tracking bugs. Instead, make individual disabled stories point to bugs tracking their specific fix and re-enable. BUG=664505 Committed: https://crrev.com/9c0d7ac829bce311c18fa420fdc97917227c0018 Cr-Commit-Position: refs/heads/master@{#440422}

Patch Set 1 #

Patch Set 2 : undo change on browse:news:cnn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M tools/perf/page_sets/system_health/background_stories.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/system_health/browsing_stories.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/system_health/loading_stories.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/system_health/long_running_stories.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
perezju
4 years ago (2016-12-21 16:55:59 UTC) #2
perezju
I undid the change on browse:news:cnn, otherwise it's going to cause a conflict with https://codereview.chromium.org/2592933003/
4 years ago (2016-12-21 17:06:00 UTC) #3
perezju
ping :)
4 years ago (2016-12-22 14:02:28 UTC) #4
nednguyen
On 2016/12/22 14:02:28, perezju wrote: > ping :) sorry lgtm
4 years ago (2016-12-22 14:09:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598693002/20001
4 years ago (2016-12-22 14:09:53 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-22 15:17:43 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-22 15:21:30 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9c0d7ac829bce311c18fa420fdc97917227c0018
Cr-Commit-Position: refs/heads/master@{#440422}

Powered by Google App Engine
This is Rietveld 408576698