Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2598673002:
Update TaskTraits in keystone_glue.mm. (Closed)
DescriptionUpdate TaskTraits in keystone_glue.mm.
The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73HeKIjX7HQqwSWOnF8/edit?usp=sharing
.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).
.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.
R=gab@chromium.org
TBR=mark@chromium.org
BUG=675660
Committed: https://crrev.com/668d7b5e35dacbae7e4025067c21f6f345b692aa
Cr-Commit-Position: refs/heads/master@{#440397}
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
fdoray@chromium.org changed reviewers: + mark@chromium.org
PTAL
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Update TaskTraits in keystone_glue.mm. The .WithFileIO() and .WithWait() traits were deprecated in favor of .MayBlock() and .WithSyncPrimitives(). See rationale in https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73... .MayBlock() Tasks with this trait may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait does not allow tasks to wait on synchronization primitives (thread or process handles, waitable events, condition variables). .WithSyncPrimitives() Tasks with this trait are allowed to block on synchronization primitives (wait on a waitable event/condition variable, join a process/thread). This trait implies MayBlock(), i.e. you do not need to specify MayBlock() for a task that blocks exclusively on synchronization primitives. R=gab@chromium.org BUG=675660 ========== to ========== Update TaskTraits in keystone_glue.mm. The .WithFileIO() and .WithWait() traits were deprecated in favor of .MayBlock() and .WithSyncPrimitives(). See rationale in https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73... .MayBlock() Tasks with this trait may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait does not allow tasks to wait on synchronization primitives (thread or process handles, waitable events, condition variables). .WithSyncPrimitives() Tasks with this trait are allowed to block on synchronization primitives (wait on a waitable event/condition variable, join a process/thread). This trait implies MayBlock(), i.e. you do not need to specify MayBlock() for a task that blocks exclusively on synchronization primitives. R=gab@chromium.org TBR=mark@chromium.org BUG=675660 ==========
TBR=mark@chromium.org for a trivial search-and-replace
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482411375110520, "parent_rev":
"4131d3b410f96df38b2ce624bfa979eadc144b1f", "commit_rev":
"3f86f37af303a4b4abc8973a6316bea2e0709837"}
Message was sent while issue was closed.
Description was changed from ========== Update TaskTraits in keystone_glue.mm. The .WithFileIO() and .WithWait() traits were deprecated in favor of .MayBlock() and .WithSyncPrimitives(). See rationale in https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73... .MayBlock() Tasks with this trait may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait does not allow tasks to wait on synchronization primitives (thread or process handles, waitable events, condition variables). .WithSyncPrimitives() Tasks with this trait are allowed to block on synchronization primitives (wait on a waitable event/condition variable, join a process/thread). This trait implies MayBlock(), i.e. you do not need to specify MayBlock() for a task that blocks exclusively on synchronization primitives. R=gab@chromium.org TBR=mark@chromium.org BUG=675660 ========== to ========== Update TaskTraits in keystone_glue.mm. The .WithFileIO() and .WithWait() traits were deprecated in favor of .MayBlock() and .WithSyncPrimitives(). See rationale in https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73... .MayBlock() Tasks with this trait may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait does not allow tasks to wait on synchronization primitives (thread or process handles, waitable events, condition variables). .WithSyncPrimitives() Tasks with this trait are allowed to block on synchronization primitives (wait on a waitable event/condition variable, join a process/thread). This trait implies MayBlock(), i.e. you do not need to specify MayBlock() for a task that blocks exclusively on synchronization primitives. R=gab@chromium.org TBR=mark@chromium.org BUG=675660 Review-Url: https://codereview.chromium.org/2598673002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Update TaskTraits in keystone_glue.mm. The .WithFileIO() and .WithWait() traits were deprecated in favor of .MayBlock() and .WithSyncPrimitives(). See rationale in https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73... .MayBlock() Tasks with this trait may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait does not allow tasks to wait on synchronization primitives (thread or process handles, waitable events, condition variables). .WithSyncPrimitives() Tasks with this trait are allowed to block on synchronization primitives (wait on a waitable event/condition variable, join a process/thread). This trait implies MayBlock(), i.e. you do not need to specify MayBlock() for a task that blocks exclusively on synchronization primitives. R=gab@chromium.org TBR=mark@chromium.org BUG=675660 Review-Url: https://codereview.chromium.org/2598673002 ========== to ========== Update TaskTraits in keystone_glue.mm. The .WithFileIO() and .WithWait() traits were deprecated in favor of .MayBlock() and .WithSyncPrimitives(). See rationale in https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73... .MayBlock() Tasks with this trait may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait does not allow tasks to wait on synchronization primitives (thread or process handles, waitable events, condition variables). .WithSyncPrimitives() Tasks with this trait are allowed to block on synchronization primitives (wait on a waitable event/condition variable, join a process/thread). This trait implies MayBlock(), i.e. you do not need to specify MayBlock() for a task that blocks exclusively on synchronization primitives. R=gab@chromium.org TBR=mark@chromium.org BUG=675660 Committed: https://crrev.com/668d7b5e35dacbae7e4025067c21f6f345b692aa Cr-Commit-Position: refs/heads/master@{#440397} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/668d7b5e35dacbae7e4025067c21f6f345b692aa Cr-Commit-Position: refs/heads/master@{#440397}
Message was sent while issue was closed.
LGTM |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
