[CacheStorage] Fix ownership of doomed cache as it's cleaned up

[CacheStorage] Fix ownership of doomed cache as it's cleaned up

Releasing of a doomed handle winds up passing
std::unique_ptr<CacheStorageCache> values around in callbacks. Rather than the
callback owning the cache, let's keep it in the CacheStorage's doomed_caches_
object so that ownership is always clear and to maintain the invariant that Caches are destructed before their respective CacheStorage is.

BUG=676325
Committed: https://crrev.com/e8992984e25e4a4fcfb88d3164379754b6df2879
Cr-Commit-Position: refs/heads/master@{#440149}

[jkarlin, 2016-12-21 15:35:24]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 15:35:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-12-21 15:37:05]

Description was changed from

==========
[CacheStorage] Fix ownership of doomed cache as it's cleaned up

Releasing of a doomed handle winds up passing
std::unique_ptr<CacheStorageCache> values around in callbacks. Rather than the
callback owning the cache, let's keep it in the CacheStorage's doomed_caches_
object so that ownership is always clear.

BUG=676325
==========

to

==========
[CacheStorage] Fix ownership of doomed cache as it's cleaned up

Releasing of a doomed handle winds up passing
std::unique_ptr<CacheStorageCache> values around in callbacks. Rather than the
callback owning the cache, let's keep it in the CacheStorage's doomed_caches_
object so that ownership is always clear.

BUG=676325
==========

[jkarlin, 2016-12-21 15:37:05]

jkarlin@chromium.org changed reviewers:
+ cmumford@chromium.org

[jkarlin, 2016-12-21 15:37:36]

cmumford@ PTAL, thanks!

[jkarlin, 2016-12-21 15:38:37]

Description was changed from

==========
[CacheStorage] Fix ownership of doomed cache as it's cleaned up

Releasing of a doomed handle winds up passing
std::unique_ptr<CacheStorageCache> values around in callbacks. Rather than the
callback owning the cache, let's keep it in the CacheStorage's doomed_caches_
object so that ownership is always clear.

BUG=676325
==========

to

==========
[CacheStorage] Fix ownership of doomed cache as it's cleaned up

Releasing of a doomed handle winds up passing
std::unique_ptr<CacheStorageCache> values around in callbacks. Rather than the
callback owning the cache, let's keep it in the CacheStorage's doomed_caches_
object so that ownership is always clear and to maintain the invariant that
Caches are destructed before their respective CacheStorage is.

BUG=676325
==========

[cmumford, 2016-12-21 17:15:54]

lgtm

[jkarlin, 2016-12-21 17:30:56]

The CQ bit was unchecked by jkarlin@chromium.org

[jkarlin, 2016-12-21 17:31:00]

The CQ bit was checked by jkarlin@chromium.org

[jkarlin, 2016-12-21 17:31:06]

Thanks!

[commit-bot: I haz the power, 2016-12-21 17:31:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 18:03:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482341460700890, "parent_rev":
"c53d6029ac5a748a6b70d40c09f47206b05f67cd", "commit_rev":
"861a3e87b7361424137f15684c7dfb1571fb09d7"}

[commit-bot: I haz the power, 2016-12-21 18:04:17]

Description was changed from

==========
[CacheStorage] Fix ownership of doomed cache as it's cleaned up

Releasing of a doomed handle winds up passing
std::unique_ptr<CacheStorageCache> values around in callbacks. Rather than the
callback owning the cache, let's keep it in the CacheStorage's doomed_caches_
object so that ownership is always clear and to maintain the invariant that
Caches are destructed before their respective CacheStorage is.

BUG=676325
==========

to

==========
[CacheStorage] Fix ownership of doomed cache as it's cleaned up

Releasing of a doomed handle winds up passing
std::unique_ptr<CacheStorageCache> values around in callbacks. Rather than the
callback owning the cache, let's keep it in the CacheStorage's doomed_caches_
object so that ownership is always clear and to maintain the invariant that
Caches are destructed before their respective CacheStorage is.

BUG=676325

Review-Url: https://codereview.chromium.org/2598643002
==========

[commit-bot: I haz the power, 2016-12-21 18:04:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-21 18:06:50]

Description was changed from

==========
[CacheStorage] Fix ownership of doomed cache as it's cleaned up

Releasing of a doomed handle winds up passing
std::unique_ptr<CacheStorageCache> values around in callbacks. Rather than the
callback owning the cache, let's keep it in the CacheStorage's doomed_caches_
object so that ownership is always clear and to maintain the invariant that
Caches are destructed before their respective CacheStorage is.

BUG=676325

Review-Url: https://codereview.chromium.org/2598643002
==========

to

==========
[CacheStorage] Fix ownership of doomed cache as it's cleaned up

Releasing of a doomed handle winds up passing
std::unique_ptr<CacheStorageCache> values around in callbacks. Rather than the
callback owning the cache, let's keep it in the CacheStorage's doomed_caches_
object so that ownership is always clear and to maintain the invariant that
Caches are destructed before their respective CacheStorage is.

BUG=676325

Committed: https://crrev.com/e8992984e25e4a4fcfb88d3164379754b6df2879
Cr-Commit-Position: refs/heads/master@{#440149}
==========

[commit-bot: I haz the power, 2016-12-21 18:06:50]

Patchset 1 (id:??) landed as
https://crrev.com/e8992984e25e4a4fcfb88d3164379754b6df2879
Cr-Commit-Position: refs/heads/master@{#440149}