Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years ago by bbudge Modified:
4 years ago Reviewers:
titzer, Rodolph Perfetta (ARM) CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[WASM] Skip SIMD test values that may result in denormalized numbers.
On ARM Neon at least, denormals flush to zero, which may not match
regular FP behavior.
LOG=N
BUG=v8:4124
Review-Url: https://codereview.chromium.org/2598583002
Cr-Commit-Position: refs/heads/master@{#41895}
Committed: https://chromium.googlesource.com/v8/v8/+/7a6138ae11b7e1108bb3ced923993a3dc2def4eb
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add a TODO. #
Created: 4 years ago
Messages
Total messages: 15 (9 generated)
The CQ bit was checked by bbudge@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bbudge@chromium.org changed reviewers: + rodolph.perfetta@arm.com, titzer@chromium.org
This is intended to fix test failures on ARM hardware: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug/bu...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2598583002/diff/1/test/cctest/wasm/test-run-w... File test/cctest/wasm/test-run-wasm-simd.cc (right): https://codereview.chromium.org/2598583002/diff/1/test/cctest/wasm/test-run-w... test/cctest/wasm/test-run-wasm-simd.cc:239: float expected = expected_op(*i, *j); IIUC, arm does flush-to-zero for sub-normal numbers, so we could make this check more strict and check against zero. Can you add a TODO here to that effect?
https://codereview.chromium.org/2598583002/diff/1/test/cctest/wasm/test-run-w... File test/cctest/wasm/test-run-wasm-simd.cc (right): https://codereview.chromium.org/2598583002/diff/1/test/cctest/wasm/test-run-w... test/cctest/wasm/test-run-wasm-simd.cc:239: float expected = expected_op(*i, *j); On 2016/12/21 10:19:08, titzer wrote: > IIUC, arm does flush-to-zero for sub-normal numbers, so we could make this check > more strict and check against zero. > > Can you add a TODO here to that effect? Done.
The CQ bit was checked by bbudge@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org Link to the patchset: https://codereview.chromium.org/2598583002/#ps20001 (title: "Add a TODO.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482332623150920,
"parent_rev": "679b31c21425ecdd86c40a8a02ac131b72f7bc6b", "commit_rev":
"7a6138ae11b7e1108bb3ced923993a3dc2def4eb"}
Message was sent while issue was closed.
Description was changed from ========== [WASM] Skip SIMD test values that may result in denormalized numbers. On ARM Neon at least, denormals flush to zero, which may not match regular FP behavior. LOG=N BUG=v8:4124 ========== to ========== [WASM] Skip SIMD test values that may result in denormalized numbers. On ARM Neon at least, denormals flush to zero, which may not match regular FP behavior. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2598583002 Cr-Commit-Position: refs/heads/master@{#41895} Committed: https://chromium.googlesource.com/v8/v8/+/7a6138ae11b7e1108bb3ced923993a3dc2d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/7a6138ae11b7e1108bb3ced923993a3dc2d... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
