Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2598563002: Options length setter should process custom elements reactions (Closed)

Created:
4 years ago by dominicc (has gone to gerrit)
Modified:
4 years ago
Reviewers:
Xiaocheng
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Options length setter should process custom elements reactions Unlike HTMLCollections, the HTMLOptionsCollection length attribute is writable and it can remove elements from the DOM on truncation, which should trigger custom element reactions. Add the metadata to do that. This means Blink is now passing web-platform-tests' custom-elements/reactions/HTMLOptionsCollection.html tests. BUG=676257 Committed: https://crrev.com/4a578d12a688c40523cc326151606f5ea4f50fb9 Cr-Commit-Position: refs/heads/master@{#440331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
D third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/HTMLOptionsCollection-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptionsCollection.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
dominicc (has gone to gerrit)
PTAL
4 years ago (2016-12-21 08:40:14 UTC) #4
Xiaocheng
lgtm
4 years ago (2016-12-21 08:52:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598563002/1
4 years ago (2016-12-22 03:43:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 03:50:01 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-22 03:53:51 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a578d12a688c40523cc326151606f5ea4f50fb9
Cr-Commit-Position: refs/heads/master@{#440331}

Powered by Google App Engine
This is Rietveld 408576698