Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2598543002:
Re-add the threading assertion on Android WebMidi implementation (Closed)
|
Created:
4 years ago by yhirano Modified:
4 years ago Reviewers:
Takashi Toyoshima CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org, agrieve+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRe-add the threading assertion on Android WebMidi implementation
BUG=665157
Committed: https://crrev.com/8559e6864ffc0080ab3991501d3712110a3c92f2
Cr-Commit-Position: refs/heads/master@{#440069}
Patch Set 1 #Patch Set 2 : fix #Messages
Total messages: 17 (12 generated)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Re-add the thread affinity assertion on Android WebMidi implementation BUG=665157 ========== to ========== Re-add the threading assertion on Android WebMidi implementation BUG=665157 ==========
yhirano@chromium.org changed reviewers: + toyoshim@chromium.org
PTAL. See the try fails with PS1 and passes with PS2. Assertion is working. I sought for runningOnIOThread or something, but failed. So I'm using !runningOnUiThread instead.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by yhirano@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482315563927010,
"parent_rev": "ac9e6c009895b9e8bff668ba566fbb8b541a5ece", "commit_rev":
"26cdb0840d1e08548463ece48c174a639cb978e8"}
Message was sent while issue was closed.
Description was changed from ========== Re-add the threading assertion on Android WebMidi implementation BUG=665157 ========== to ========== Re-add the threading assertion on Android WebMidi implementation BUG=665157 Review-Url: https://codereview.chromium.org/2598543002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Re-add the threading assertion on Android WebMidi implementation BUG=665157 Review-Url: https://codereview.chromium.org/2598543002 ========== to ========== Re-add the threading assertion on Android WebMidi implementation BUG=665157 Committed: https://crrev.com/8559e6864ffc0080ab3991501d3712110a3c92f2 Cr-Commit-Position: refs/heads/master@{#440069} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8559e6864ffc0080ab3991501d3712110a3c92f2 Cr-Commit-Position: refs/heads/master@{#440069} |
