Revert of Use xvfb with Ozone CrOS.

Revert of Use xvfb with Ozone CrOS. (patchset #2 id:20001 of https://codereview.chromium.org/2587473002/ )

Reason for revert:
Suspecting that this is causing intermittent bot crashes on after gl_unittests runs. See crbug.com/676128 for more details.

Original issue's description:
> Use xvfb with Ozone CrOS.
>
> We want to switch the majority of Ozone CrOS tests over to run with
> --ozone-platform=x11. This requires that test targets with type
> 'windowed_test_launcher' run using xvfb.
>
> Right now mb.py looks for the arg '--ozone-platform=x11' in the isolate
> step, which requires adding a new target for each test we want to add.
> Instead, just assume that if use_ozone=true and target_os="chromeos"
> then we want to use xvfb.
>
> Ozone CrOS test with type 'windowed_test_launcher' will still need to
> have '--ozone-platform=x11' flag added in chromimum.chromiumos.json to
> run with Ozone X11. Once most tests pass under with Ozone X11 the
> default Ozone platform can be swapped to be x11 and only tests that
> should run with headless will require an args entry there.
>
> BUG=671355
>
> Committed: https://crrev.com/ed64274506538a9770b7bf86df7eef2ecb4948b7
> Cr-Commit-Position: refs/heads/master@{#439557}

TBR=dpranke@chromium.org,rjkroege@chromium.org,sadrul@chromium.org,kylechar@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671355, 676128
Committed: https://crrev.com/faa7892bed1c4340b84d37abc506fbb3f17615c2
Cr-Commit-Position: refs/heads/master@{#439980}

[vmpstr, 2016-12-21 00:46:58]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2016-12-21 00:46:58]

Created Revert of Use xvfb with Ozone CrOS.

[vmpstr, 2016-12-21 00:47:14]

The CQ bit was unchecked by vmpstr@chromium.org

[vmpstr, 2016-12-21 00:47:28]

Description was changed from

==========
Revert of Use xvfb with Ozone CrOS. (patchset #2 id:20001 of
https://codereview.chromium.org/2587473002/ )

Reason for revert:
Suspecting that this is causing intermittent bot crashes on after gl_unittests
runs. See crbug.com/676128 for more details.

Original issue's description:
> Use xvfb with Ozone CrOS.
> 
> We want to switch the majority of Ozone CrOS tests over to run with
> --ozone-platform=x11. This requires that test targets with type
> 'windowed_test_launcher' run using xvfb.
> 
> Right now mb.py looks for the arg '--ozone-platform=x11' in the isolate
> step, which requires adding a new target for each test we want to add.
> Instead, just assume that if use_ozone=true and target_os="chromeos"
> then we want to use xvfb.
> 
> Ozone CrOS test with type 'windowed_test_launcher' will still need to
> have '--ozone-platform=x11' flag added in chromimum.chromiumos.json to
> run with Ozone X11. Once most tests pass under with Ozone X11 the
> default Ozone platform can be swapped to be x11 and only tests that
> should run with headless will require an args entry there.
> 
> BUG=671355
> 
> Committed: https://crrev.com/ed64274506538a9770b7bf86df7eef2ecb4948b7
> Cr-Commit-Position: refs/heads/master@{#439557}

TBR=dpranke@chromium.org,rjkroege@chromium.org,sadrul@chromium.org,kylechar@c...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671355
==========

to

==========
Revert of Use xvfb with Ozone CrOS. (patchset #2 id:20001 of
https://codereview.chromium.org/2587473002/ )

Reason for revert:
Suspecting that this is causing intermittent bot crashes on after gl_unittests
runs. See crbug.com/676128 for more details.

Original issue's description:
> Use xvfb with Ozone CrOS.
> 
> We want to switch the majority of Ozone CrOS tests over to run with
> --ozone-platform=x11. This requires that test targets with type
> 'windowed_test_launcher' run using xvfb.
> 
> Right now mb.py looks for the arg '--ozone-platform=x11' in the isolate
> step, which requires adding a new target for each test we want to add.
> Instead, just assume that if use_ozone=true and target_os="chromeos"
> then we want to use xvfb.
> 
> Ozone CrOS test with type 'windowed_test_launcher' will still need to
> have '--ozone-platform=x11' flag added in chromimum.chromiumos.json to
> run with Ozone X11. Once most tests pass under with Ozone X11 the
> default Ozone platform can be swapped to be x11 and only tests that
> should run with headless will require an args entry there.
> 
> BUG=671355
> 
> Committed: https://crrev.com/ed64274506538a9770b7bf86df7eef2ecb4948b7
> Cr-Commit-Position: refs/heads/master@{#439557}

TBR=dpranke@chromium.org,rjkroege@chromium.org,sadrul@chromium.org,kylechar@c...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671355, 676128
==========

[vmpstr, 2016-12-21 00:47:33]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-12-21 00:47:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-12-21 01:20:46]

lgtm

[commit-bot: I haz the power, 2016-12-21 02:12:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482281253792780, "parent_rev":
"e1f32d80f0bc65e5728c386e696c0081dcbf3c26", "commit_rev":
"4d4e7b833dd0e1b0c1414a45c8e95001d1e19f00"}

[commit-bot: I haz the power, 2016-12-21 02:13:00]

Description was changed from

==========
Revert of Use xvfb with Ozone CrOS. (patchset #2 id:20001 of
https://codereview.chromium.org/2587473002/ )

Reason for revert:
Suspecting that this is causing intermittent bot crashes on after gl_unittests
runs. See crbug.com/676128 for more details.

Original issue's description:
> Use xvfb with Ozone CrOS.
> 
> We want to switch the majority of Ozone CrOS tests over to run with
> --ozone-platform=x11. This requires that test targets with type
> 'windowed_test_launcher' run using xvfb.
> 
> Right now mb.py looks for the arg '--ozone-platform=x11' in the isolate
> step, which requires adding a new target for each test we want to add.
> Instead, just assume that if use_ozone=true and target_os="chromeos"
> then we want to use xvfb.
> 
> Ozone CrOS test with type 'windowed_test_launcher' will still need to
> have '--ozone-platform=x11' flag added in chromimum.chromiumos.json to
> run with Ozone X11. Once most tests pass under with Ozone X11 the
> default Ozone platform can be swapped to be x11 and only tests that
> should run with headless will require an args entry there.
> 
> BUG=671355
> 
> Committed: https://crrev.com/ed64274506538a9770b7bf86df7eef2ecb4948b7
> Cr-Commit-Position: refs/heads/master@{#439557}

TBR=dpranke@chromium.org,rjkroege@chromium.org,sadrul@chromium.org,kylechar@c...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671355, 676128
==========

to

==========
Revert of Use xvfb with Ozone CrOS. (patchset #2 id:20001 of
https://codereview.chromium.org/2587473002/ )

Reason for revert:
Suspecting that this is causing intermittent bot crashes on after gl_unittests
runs. See crbug.com/676128 for more details.

Original issue's description:
> Use xvfb with Ozone CrOS.
> 
> We want to switch the majority of Ozone CrOS tests over to run with
> --ozone-platform=x11. This requires that test targets with type
> 'windowed_test_launcher' run using xvfb.
> 
> Right now mb.py looks for the arg '--ozone-platform=x11' in the isolate
> step, which requires adding a new target for each test we want to add.
> Instead, just assume that if use_ozone=true and target_os="chromeos"
> then we want to use xvfb.
> 
> Ozone CrOS test with type 'windowed_test_launcher' will still need to
> have '--ozone-platform=x11' flag added in chromimum.chromiumos.json to
> run with Ozone X11. Once most tests pass under with Ozone X11 the
> default Ozone platform can be swapped to be x11 and only tests that
> should run with headless will require an args entry there.
> 
> BUG=671355
> 
> Committed: https://crrev.com/ed64274506538a9770b7bf86df7eef2ecb4948b7
> Cr-Commit-Position: refs/heads/master@{#439557}

TBR=dpranke@chromium.org,rjkroege@chromium.org,sadrul@chromium.org,kylechar@c...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671355, 676128

Review-Url: https://codereview.chromium.org/2598483002
==========

[commit-bot: I haz the power, 2016-12-21 02:13:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-21 02:17:20]

Description was changed from

==========
Revert of Use xvfb with Ozone CrOS. (patchset #2 id:20001 of
https://codereview.chromium.org/2587473002/ )

Reason for revert:
Suspecting that this is causing intermittent bot crashes on after gl_unittests
runs. See crbug.com/676128 for more details.

Original issue's description:
> Use xvfb with Ozone CrOS.
> 
> We want to switch the majority of Ozone CrOS tests over to run with
> --ozone-platform=x11. This requires that test targets with type
> 'windowed_test_launcher' run using xvfb.
> 
> Right now mb.py looks for the arg '--ozone-platform=x11' in the isolate
> step, which requires adding a new target for each test we want to add.
> Instead, just assume that if use_ozone=true and target_os="chromeos"
> then we want to use xvfb.
> 
> Ozone CrOS test with type 'windowed_test_launcher' will still need to
> have '--ozone-platform=x11' flag added in chromimum.chromiumos.json to
> run with Ozone X11. Once most tests pass under with Ozone X11 the
> default Ozone platform can be swapped to be x11 and only tests that
> should run with headless will require an args entry there.
> 
> BUG=671355
> 
> Committed: https://crrev.com/ed64274506538a9770b7bf86df7eef2ecb4948b7
> Cr-Commit-Position: refs/heads/master@{#439557}

TBR=dpranke@chromium.org,rjkroege@chromium.org,sadrul@chromium.org,kylechar@c...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671355, 676128

Review-Url: https://codereview.chromium.org/2598483002
==========

to

==========
Revert of Use xvfb with Ozone CrOS. (patchset #2 id:20001 of
https://codereview.chromium.org/2587473002/ )

Reason for revert:
Suspecting that this is causing intermittent bot crashes on after gl_unittests
runs. See crbug.com/676128 for more details.

Original issue's description:
> Use xvfb with Ozone CrOS.
>
> We want to switch the majority of Ozone CrOS tests over to run with
> --ozone-platform=x11. This requires that test targets with type
> 'windowed_test_launcher' run using xvfb.
>
> Right now mb.py looks for the arg '--ozone-platform=x11' in the isolate
> step, which requires adding a new target for each test we want to add.
> Instead, just assume that if use_ozone=true and target_os="chromeos"
> then we want to use xvfb.
>
> Ozone CrOS test with type 'windowed_test_launcher' will still need to
> have '--ozone-platform=x11' flag added in chromimum.chromiumos.json to
> run with Ozone X11. Once most tests pass under with Ozone X11 the
> default Ozone platform can be swapped to be x11 and only tests that
> should run with headless will require an args entry there.
>
> BUG=671355
>
> Committed: https://crrev.com/ed64274506538a9770b7bf86df7eef2ecb4948b7
> Cr-Commit-Position: refs/heads/master@{#439557}

TBR=dpranke@chromium.org,rjkroege@chromium.org,sadrul@chromium.org,kylechar@c...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671355, 676128

Committed: https://crrev.com/faa7892bed1c4340b84d37abc506fbb3f17615c2
Cr-Commit-Position: refs/heads/master@{#439980}
==========

[commit-bot: I haz the power, 2016-12-21 02:17:21]

Patchset 1 (id:??) landed as
https://crrev.com/faa7892bed1c4340b84d37abc506fbb3f17615c2
Cr-Commit-Position: refs/heads/master@{#439980}

[kylechar, 2016-12-21 04:26:16]

lgtm