Use vector of unique_ptrs for page node children.

Use vector of unique_ptrs for page node children.

Also be sure that a loop terminates without relying on
specific behaviour of the callers.

Review-Url: https://codereview.chromium.org/2598473002
Committed: https://pdfium.googlesource.com/pdfium/+/aea77059d309820dbcea9ec3e583fa673960a0b9

[Tom Sepez, 2016-12-20 23:56:55]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-12-20 23:57:09]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 23:57:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 00:11:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 00:11:28]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-12-21 00:35:04]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 00:35:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-12-21 00:37:22]

Description was changed from

==========
Use vector of unique_ptrs for page node children.
==========

to

==========
Use vector of unique_ptrs for page node children.

Also be sure that a loop terminates without relying on
specific behaviour of the callers.
==========

[dsinclair, 2017-01-02 13:54:42]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2017-01-02 13:54:42]

lgtm

[commit-bot: I haz the power, 2017-01-02 13:54:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-02 14:14:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483365282249000,
"parent_rev": "d0bbccdd32113baf95ae16565c0314166d989638", "commit_rev":
"aea77059d309820dbcea9ec3e583fa673960a0b9"}

[commit-bot: I haz the power, 2017-01-02 14:14:32]

Description was changed from

==========
Use vector of unique_ptrs for page node children.

Also be sure that a loop terminates without relying on
specific behaviour of the callers.
==========

to

==========
Use vector of unique_ptrs for page node children.

Also be sure that a loop terminates without relying on
specific behaviour of the callers.

Review-Url: https://codereview.chromium.org/2598473002
Committed:
https://pdfium.googlesource.com/pdfium/+/aea77059d309820dbcea9ec3e583fa673960...
==========

[commit-bot: I haz the power, 2017-01-02 14:14:33]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/aea77059d309820dbcea9ec3e583fa673960...