Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2598463004: Replace DOMWindowProperty in DOMWindow's supplements with ContextClient (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, haraken, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace DOMWindowProperty in DOMWindow's supplements with ContextClient This is a preparation for deprecating DOMWindowProperty. BUG=610176 Committed: https://crrev.com/e1d2841edc991253b3ee04a6cd66b38547d83175 Cr-Commit-Position: refs/heads/master@{#440086}

Patch Set 1 #

Messages

Total messages: 10 (5 generated)
haraken
PTAL (At some point I want to land https://codereview.chromium.org/2150443002/ and remove ContextClients from supplement objects.)
4 years ago (2016-12-21 12:02:00 UTC) #2
sof
lgtm
4 years ago (2016-12-21 12:24:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598463004/1
4 years ago (2016-12-21 12:35:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 13:56:41 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-21 14:01:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1d2841edc991253b3ee04a6cd66b38547d83175
Cr-Commit-Position: refs/heads/master@{#440086}

Powered by Google App Engine
This is Rietveld 408576698