Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2598443002: Update text in Search Geolocation Disclosure. (Closed)

Created:
4 years ago by benwells
Modified:
4 years ago
Reviewers:
gone
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update text in Search Geolocation Disclosure. The text has been slightly updated after wide consultation and discussion. BUG=674770 Committed: https://crrev.com/b2f998ef41c702d48dd36880fc2c1eead05a5ba9 Cr-Commit-Position: refs/heads/master@{#440243}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/android/search_geolocation_disclosure_infobar_delegate.cc View 2 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
benwells
4 years ago (2016-12-20 23:32:10 UTC) #4
gone
lgtm
4 years ago (2016-12-21 19:18:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598443002/1
4 years ago (2016-12-21 22:28:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 22:33:59 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-21 22:37:14 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2f998ef41c702d48dd36880fc2c1eead05a5ba9
Cr-Commit-Position: refs/heads/master@{#440243}

Powered by Google App Engine
This is Rietveld 408576698