Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2598323002: [foozzie] Fix paths and resources (Closed)

Created:
3 years, 12 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
Reviewers:
tandrii(chromium)
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[foozzie] Fix paths and resources BUG=chromium:673246 NOTRY=true TBR=tandrii@chromium.org Review-Url: https://codereview.chromium.org/2598323002 Cr-Commit-Position: refs/heads/master@{#41954} Committed: https://chromium.googlesource.com/v8/v8/+/905d72befec43f374a1e475f4c5e034946a8a1af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M tools/foozzie/v8_foozzie.py View 2 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Michael Achenbach
TBR - the resource file isn't saved anyways and abspath doesn't give the desired results.
3 years, 12 months ago (2016-12-26 16:53:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598323002/1
3 years, 12 months ago (2016-12-26 16:53:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/905d72befec43f374a1e475f4c5e034946a8a1af
3 years, 12 months ago (2016-12-26 16:55:32 UTC) #8
tandrii(chromium)
3 years, 11 months ago (2016-12-28 14:35:34 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698