Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2598263002: Subzero: Fix a build issue against LLVM trunk. (Closed)

Created:
3 years, 12 months ago by Jim Stichnoth
Modified:
3 years, 12 months ago
Reviewers:
Eric Holk, Karl, John
CC:
native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix a build issue against LLVM trunk. The existing code gives a build error against LLVM trunk. Actually, the latest LLVM trunk causes a lot more Subzero build problems, but if we roll LLVM back to 1d79fff9e65e77f84bf80c2cf4f0155bd167c90d, everything builds except for this one issue. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=f8c695b31745752d359a19d26d7a7250ab78cc9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/IceTargetLoweringMIPS32.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
3 years, 12 months ago (2016-12-26 06:22:41 UTC) #3
Karl
lgtm
3 years, 12 months ago (2016-12-26 17:48:48 UTC) #4
Jim Stichnoth
3 years, 12 months ago (2016-12-26 17:56:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f8c695b31745752d359a19d26d7a7250ab78cc9c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698