Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2598223002: [ash-md] Fix layout of launcher and overflow buttons in Ash MD shelf (Closed)

Created:
3 years, 12 months ago by bruthig
Modified:
3 years, 11 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Fix layout of launcher and overflow buttons in Ash MD shelf This CL ensures the correct layout of the launcher button and the overflow button in the Ash MD shelf when the shelf is being resized. This can occur in two situations: when the shelf is being 'stretched' toward the center of the screen by touch, or during a shelf hide/show animation. BUG=668230 TEST=manual Review-Url: https://codereview.chromium.org/2598223002 Cr-Commit-Position: refs/heads/master@{#442031} Committed: https://chromium.googlesource.com/chromium/src/+/70ef77ca5ba5cc47a0ff9bbe35af22a13a44b819

Patch Set 1 : https://codereview.chromium.org/2579463002/#ps40001 #

Patch Set 2 : Added handling for SHELF_ALIGNMENT_BOTTOM_LOCKED. #

Patch Set 3 : Merge branch 'master' into launcher_layout_in_shelf #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -20 lines) Patch
M ash/common/shelf/app_list_button.cc View 1 1 chunk +17 lines, -10 lines 2 comments Download
M ash/common/shelf/overflow_button.cc View 1 chunk +9 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
bruthig
oshima@, Can you take a quick look at the delta between patch set 1 and ...
3 years, 11 months ago (2017-01-06 19:40:12 UTC) #8
oshima
lgtm https://codereview.chromium.org/2598223002/diff/40001/ash/common/shelf/app_list_button.cc File ash/common/shelf/app_list_button.cc (right): https://codereview.chromium.org/2598223002/diff/40001/ash/common/shelf/app_list_button.cc#newcode300 ash/common/shelf/app_list_button.cc:300: alignment == SHELF_ALIGNMENT_BOTTOM_LOCKED) { This is for lock ...
3 years, 11 months ago (2017-01-06 20:00:43 UTC) #9
oshima
lgtm
3 years, 11 months ago (2017-01-06 20:00:44 UTC) #10
bruthig
https://codereview.chromium.org/2598223002/diff/40001/ash/common/shelf/app_list_button.cc File ash/common/shelf/app_list_button.cc (right): https://codereview.chromium.org/2598223002/diff/40001/ash/common/shelf/app_list_button.cc#newcode300 ash/common/shelf/app_list_button.cc:300: alignment == SHELF_ALIGNMENT_BOTTOM_LOCKED) { On 2017/01/06 20:00:43, oshima wrote: ...
3 years, 11 months ago (2017-01-06 20:28:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598223002/40001
3 years, 11 months ago (2017-01-06 20:28:46 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 20:34:44 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/70ef77ca5ba5cc47a0ff9bbe35af...

Powered by Google App Engine
This is Rietveld 408576698