Allow FilePathWatcher to be used from sequenced tasks.

Allow FilePathWatcher to be used from sequenced tasks.

This CL allows FilePathWatcher to be used from sequenced
tasks. Notifications are dispatched on the sequence from
which Watch() is called. Previously, it had to be used
from single-threaded tasks.

BUG=675631
Committed: https://crrev.com/caa1245b3c7c6e75f3e79139bf6d90eb2227d953
Cr-Commit-Position: refs/heads/master@{#440649}

[fdoray, 2016-12-23 14:08:59]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 14:09:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-12-23 14:09:21]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org

[fdoray, 2016-12-23 14:09:21]

PTAL

[commit-bot: I haz the power, 2016-12-23 15:07:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 15:07:19]

Dry run: This issue passed the CQ dry run.

[gab, 2016-12-23 15:35:14]

LGTM w/ comment

https://codereview.chromium.org/2598193002/diff/1/base/files/file_path_watcher.h
File base/files/file_path_watcher.h (right):

https://codereview.chromium.org/2598193002/diff/1/base/files/file_path_watche...
base/files/file_path_watcher.h:94: // children. The callback will be invoked on
the same thread. Returns true on
Update "thread"

[fdoray, 2016-12-23 17:37:42]

https://codereview.chromium.org/2598193002/diff/1/base/files/file_path_watcher.h
File base/files/file_path_watcher.h (right):

https://codereview.chromium.org/2598193002/diff/1/base/files/file_path_watche...
base/files/file_path_watcher.h:94: // children. The callback will be invoked on
the same thread. Returns true on
On 2016/12/23 15:35:14, gab (HOHOHO) wrote:
> Update "thread"

Done.

[fdoray, 2016-12-23 17:37:52]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-12-23 17:37:53]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2598193002/#ps20001
(title: "thread -> sequence in comment")

[commit-bot: I haz the power, 2016-12-23 17:37:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 18:56:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482514672759460,
"parent_rev": "8bd74d87dd58e9e8b8cbe607e02d2023de11228e", "commit_rev":
"afb7eeae3a2d76ad4dfaa24f5dedec156f3a864e"}

[commit-bot: I haz the power, 2016-12-23 18:57:21]

Description was changed from

==========
Allow FilePathWatcher to be used from sequenced tasks.

This CL allows FilePathWatcher to be used from sequenced
tasks. Notifications are dispatched on the sequence from
which Watch() is called. Previously, it had to be used
from single-threaded tasks.

BUG=675631
==========

to

==========
Allow FilePathWatcher to be used from sequenced tasks.

This CL allows FilePathWatcher to be used from sequenced
tasks. Notifications are dispatched on the sequence from
which Watch() is called. Previously, it had to be used
from single-threaded tasks.

BUG=675631

Review-Url: https://codereview.chromium.org/2598193002
==========

[commit-bot: I haz the power, 2016-12-23 18:57:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-23 19:00:58]

Description was changed from

==========
Allow FilePathWatcher to be used from sequenced tasks.

This CL allows FilePathWatcher to be used from sequenced
tasks. Notifications are dispatched on the sequence from
which Watch() is called. Previously, it had to be used
from single-threaded tasks.

BUG=675631

Review-Url: https://codereview.chromium.org/2598193002
==========

to

==========
Allow FilePathWatcher to be used from sequenced tasks.

This CL allows FilePathWatcher to be used from sequenced
tasks. Notifications are dispatched on the sequence from
which Watch() is called. Previously, it had to be used
from single-threaded tasks.

BUG=675631

Committed: https://crrev.com/caa1245b3c7c6e75f3e79139bf6d90eb2227d953
Cr-Commit-Position: refs/heads/master@{#440649}
==========

[commit-bot: I haz the power, 2016-12-23 19:00:59]

Patchset 2 (id:??) landed as
https://crrev.com/caa1245b3c7c6e75f3e79139bf6d90eb2227d953
Cr-Commit-Position: refs/heads/master@{#440649}