Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1370)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java

Issue 2598163002: WebContentsObserver update for PlzNavigate methods (Closed)
Patch Set: Fixed AwWebContentsObserver Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java
index 901b62b51f70f11bef575b192284684282548dd1..7a79e5f8d8ba61f9d76f73bb68179883641497ff 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java
@@ -26,6 +26,7 @@ import org.chromium.chrome.browser.tabmodel.document.TabDelegate;
import org.chromium.chrome.browser.widget.ControlContainer;
import org.chromium.content.browser.ContentViewCore;
import org.chromium.content_public.browser.LoadUrlParams;
+import org.chromium.content_public.browser.NavigationHandle;
import org.chromium.content_public.browser.WebContents;
import org.chromium.content_public.browser.WebContentsObserver;
@@ -169,9 +170,8 @@ public abstract class FullScreenActivity extends ChromeActivity {
ContentViewCore.fromWebContents(webContents).setFullscreenRequiredForOrientationLock(false);
mWebContentsObserver = new WebContentsObserver(webContents) {
@Override
- public void didCommitProvisionalLoadForFrame(
- long frameId, boolean isMainFrame, String url, int transitionType) {
- if (!isMainFrame) return;
+ public void didFinishNavigation(NavigationHandle navigation) {
+ if (!navigation.isInMainFrame()) return;
// Notify the renderer to permanently hide the top controls since they do
// not apply to fullscreen content views.
mTab.updateBrowserControlsState(mTab.getBrowserControlsStateConstraints(), true);

Powered by Google App Engine
This is Rietveld 408576698