chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java - Issue 2598163002: WebContentsObserver update for PlzNavigate methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

Issue 2598163002: WebContentsObserver update for PlzNavigate methods (Closed)

Patch Set: Fixed AwWebContentsObserver Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java » ('j') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

index 7fe6078f54e75e97ce5d998d8e3010b3929a6dc6..cae211e8e9b1f56d399de3c813e3dc4805190826 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

@@ -21,6 +21,7 @@ import org.chromium.chrome.browser.metrics.UmaSessionStats;

import org.chromium.chrome.browser.metrics.UmaUtils;

import org.chromium.chrome.browser.policy.PolicyAuditor;

import org.chromium.chrome.browser.policy.PolicyAuditor.AuditEvent;

+import org.chromium.content_public.browser.NavigationHandle;

import org.chromium.content_public.browser.WebContents;

import org.chromium.content_public.browser.WebContentsObserver;

@@ -147,9 +148,10 @@ public class TabWebContentsObserver extends WebContentsObserver {

}

@Override

- public void didFinishNavigation(

- boolean isMainFrame, boolean isErrorPage, boolean hasCommitted) {

- if (isMainFrame && hasCommitted) mTab.setIsShowingErrorPage(isErrorPage);

+ public void didFinishNavigation(NavigationHandle navigation) {

+ if (navigation.isInMainFrame() && navigation.hasCommitted()) {

+ mTab.setIsShowingErrorPage(navigation.isErrorPage());

+ }

}

@Override