Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2598153002: Subzero: Legalize the movzx argument. (Closed)

Created:
4 years ago by Jim Stichnoth
Modified:
3 years, 12 months ago
Reviewers:
Eric Holk, Karl, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Legalize the movzx argument. The movzx operand must be a register or memory operand. An immediate operand is not allowed. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4384 R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=373913fa0a4c7c4dd23ada9e6b4e1780fdea0096

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/IceTargetLoweringX86BaseImpl.h View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Jim Stichnoth
4 years ago (2016-12-23 05:09:31 UTC) #3
John
lgtm
4 years ago (2016-12-23 05:33:05 UTC) #4
Jim Stichnoth
3 years, 12 months ago (2016-12-23 14:07:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
373913fa0a4c7c4dd23ada9e6b4e1780fdea0096 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698