Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Issue 2598053002: Create run_all_tests script. (Closed)

Created:
4 years ago by Robert Ogden
Modified:
4 years ago
Reviewers:
RyanSturm
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create run_all_tests script. Adds a simple script to run all tests. Refactors the IntegrationTest.RunAllTests() method to be generic. BUG=669956 Committed: https://crrev.com/b14ad5a6b380c208012bc21e5899669fca9a3eae Cr-Commit-Position: refs/heads/master@{#440482}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make start_directory work under all conditions #

Patch Set 3 : Something cleaner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M tools/chrome_proxy/webdriver/common.py View 1 2 1 chunk +13 lines, -6 lines 0 comments Download
A tools/chrome_proxy/webdriver/run_all_tests.py View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Robert Ogden
I think I figured it out. Let me know if you have a better idea.
4 years ago (2016-12-22 18:20:21 UTC) #2
RyanSturm
lgtm % make sure the discover start directory is the directory of the initial script. ...
4 years ago (2016-12-22 18:40:20 UTC) #3
Robert Ogden
https://codereview.chromium.org/2598053002/diff/1/tools/chrome_proxy/webdriver/common.py File tools/chrome_proxy/webdriver/common.py (right): https://codereview.chromium.org/2598053002/diff/1/tools/chrome_proxy/webdriver/common.py#newcode545 tools/chrome_proxy/webdriver/common.py:545: tests = loader.discover('.', pattern=pattern) On 2016/12/22 18:40:20, Ryan Sturm ...
4 years ago (2016-12-22 18:53:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598053002/40001
4 years ago (2016-12-22 19:45:35 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-22 20:06:28 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-22 20:09:06 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b14ad5a6b380c208012bc21e5899669fca9a3eae
Cr-Commit-Position: refs/heads/master@{#440482}

Powered by Google App Engine
This is Rietveld 408576698