Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2598033003: Revert of Enable BrowserScheduler.RedirectHistoryService experiment on trunk. (Closed)

Created:
3 years, 12 months ago by gab
Modified:
3 years, 12 months ago
Reviewers:
gab, rkaplow, sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable BrowserScheduler.RedirectHistoryService experiment on trunk. (patchset #6 id:120001 of https://codereview.chromium.org/2592813002/ ) Revert adapted from https://codereview.chromium.org/2597013005/ to apply on trunk. Reason for revert: Suspecting this CL of causing test failures: ProfileBrowserTest.CreateNewProfileSynchronous ProfileBrowserTest.OffTheRecordURLRequestContextIsolation ProfileBrowserTest.CreateOldProfileSynchronous ProfileBrowserTest.ExitType b/c error messages mention HistoryBackend https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/25845 Original issue's description: > Enable BrowserScheduler.RedirectHistoryService experiment on trunk. > > Add .WithSyncPrimitives() trait to history service's backend > TaskRunner. Required by ChromeHistoryBackendClient::IsBookmarked(). > > BUG=661143 > TBR=sky@chromium.org (history_service.cc tweak to experiment) > > Committed: https://crrev.com/4aa30591e0953da7e0c54ffdb91856e496d16b5f > Cr-Commit-Position: refs/heads/master@{#440418} TBR=rkaplow@chromium.org,sky@chromium.org,gab@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=661143 Committed: https://crrev.com/2885403f92c9ab0a8769c2c41e859502da5a7e6f Cr-Commit-Position: refs/heads/master@{#440479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M testing/variations/fieldtrial_testing_config.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598033003/1
3 years, 12 months ago (2016-12-22 19:53:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-22 19:55:01 UTC) #5
commit-bot: I haz the power
3 years, 12 months ago (2016-12-22 19:58:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2885403f92c9ab0a8769c2c41e859502da5a7e6f
Cr-Commit-Position: refs/heads/master@{#440479}

Powered by Google App Engine
This is Rietveld 408576698