Chromium Code Reviews| Index: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc |
| diff --git a/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc b/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc |
| index afb516270b918d2d79994e775a84ed014f6733c7..a5360ac04a4cf9f2131ccbadf0fe0d26a88820c6 100644 |
| --- a/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc |
| +++ b/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc |
| @@ -54,10 +54,10 @@ class Task { |
| // These are special functions that we don't rename so that range-based |
| // for loops and STL things work. |
| - MyIterator begin() {} |
| - my_iterator end() {} |
| - my_iterator rbegin() {} |
| - MyIterator rend() {} |
| + MyIterator begin() { return {}; } |
| + my_iterator end() { return {}; } |
| + my_iterator rbegin() { return {}; } |
| + MyIterator rend() { return {}; } |
|
dcheng
2016/12/22 10:26:22
This was spamming my debug sessions, so I fixed it
Łukasz Anforowicz
2016/12/22 17:34:36
Acknowledged.
|
| // The trace() method is used by Oilpan, but we plan to tweak the Oilpan's |
| // clang plugin, so that it recognizes the new method name. |
| void trace() {} |
| @@ -69,8 +69,8 @@ class Task { |
| class Other { |
| // Static begin/end/trace don't count, and should be renamed. |
| - static MyIterator begin() {} |
| - static my_iterator end() {} |
| + static MyIterator begin() { return {}; } |
| + static my_iterator end() { return {}; } |
| static void trace() {} |
| static void lock() {} |
| }; |