Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc

Issue 2597863002: rewrite_to_chrome_style: associate replacements with the affected file (Closed)
Patch Set: actually implement stuff Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gen/thing.h" 5 #include "gen/thing.h"
6 6
7 namespace v8 { 7 namespace v8 {
8 8
9 class InterfaceOutsideOfBlink { 9 class InterfaceOutsideOfBlink {
10 public: 10 public:
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 return *this; 47 return *this;
48 } 48 }
49 49
50 // Conversion functions should not be rewritten. 50 // Conversion functions should not be rewritten.
51 explicit operator int() const { 51 explicit operator int() const {
52 return 42; 52 return 42;
53 } 53 }
54 54
55 // These are special functions that we don't rename so that range-based 55 // These are special functions that we don't rename so that range-based
56 // for loops and STL things work. 56 // for loops and STL things work.
57 MyIterator begin() {} 57 MyIterator begin() { return {}; }
58 my_iterator end() {} 58 my_iterator end() { return {}; }
59 my_iterator rbegin() {} 59 my_iterator rbegin() { return {}; }
60 MyIterator rend() {} 60 MyIterator rend() { return {}; }
dcheng 2016/12/22 10:26:22 This was spamming my debug sessions, so I fixed it
Łukasz Anforowicz 2016/12/22 17:34:36 Acknowledged.
61 // The trace() method is used by Oilpan, but we plan to tweak the Oilpan's 61 // The trace() method is used by Oilpan, but we plan to tweak the Oilpan's
62 // clang plugin, so that it recognizes the new method name. 62 // clang plugin, so that it recognizes the new method name.
63 void trace() {} 63 void trace() {}
64 // These are used by std::unique_lock and std::lock_guard. 64 // These are used by std::unique_lock and std::lock_guard.
65 void lock() {} 65 void lock() {}
66 void unlock() {} 66 void unlock() {}
67 void try_lock() {} 67 void try_lock() {}
68 }; 68 };
69 69
70 class Other { 70 class Other {
71 // Static begin/end/trace don't count, and should be renamed. 71 // Static begin/end/trace don't count, and should be renamed.
72 static MyIterator begin() {} 72 static MyIterator begin() { return {}; }
73 static my_iterator end() {} 73 static my_iterator end() { return {}; }
74 static void trace() {} 74 static void trace() {}
75 static void lock() {} 75 static void lock() {}
76 }; 76 };
77 77
78 // Test that the actual method definition is also updated. 78 // Test that the actual method definition is also updated.
79 void Task::doTheWork() { 79 void Task::doTheWork() {
80 reallyDoTheWork(); 80 reallyDoTheWork();
81 } 81 }
82 82
83 template <typename T> 83 template <typename T>
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 static void method(); 263 static void method();
264 }; 264 };
265 265
266 } // namespace internal 266 } // namespace internal
267 267
268 } // namespace blink 268 } // namespace blink
269 269
270 // https://crbug.com/640688 - need to rewrite method name below. 270 // https://crbug.com/640688 - need to rewrite method name below.
271 void blink::ClassDeclaredInsideBlink::methodDefinedOutsideBlink() {} 271 void blink::ClassDeclaredInsideBlink::methodDefinedOutsideBlink() {}
272 void blink::internal::InternalClass::method() {} 272 void blink::internal::InternalClass::method() {}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698