Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2597803002: Re-enable HttpsEngagementMetricsProvider (Closed)

Created:
4 years ago by meacer
Modified:
3 years, 12 months ago
Reviewers:
Mark P
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable HttpsEngagementMetricsProvider The crash caused by looking up the last used profile has been fixed by https://crrev.com/2531023002. This change re-enables the service. BUG=671579 Committed: https://crrev.com/b221cf432bc597a0d877627f045b7a6e8df6d647 Cr-Commit-Position: refs/heads/master@{#440456}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/metrics/chrome_metrics_service_client.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
meacer
mpearson: Can you PTAL? Thanks.
4 years ago (2016-12-22 00:48:31 UTC) #6
Mark P
lgtm
4 years ago (2016-12-22 04:41:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597803002/1
3 years, 12 months ago (2016-12-22 18:28:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-22 18:34:28 UTC) #12
commit-bot: I haz the power
3 years, 12 months ago (2016-12-22 18:38:05 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b221cf432bc597a0d877627f045b7a6e8df6d647
Cr-Commit-Position: refs/heads/master@{#440456}

Powered by Google App Engine
This is Rietveld 408576698