Fix issue with signing in after ChromeVox was enabled in login screen

Fix issue with signing in after ChromeVox was enabled in login screen

The call to AccessibilityExtensionLoader::SetProfile from
AccessibilityManager::SetProfile was causing a race condition that left
ChromeVox in a partially-loaded state, i.e. the extension was active but
AccessibilityManager thought it was not.

It turns out this call isn't necessary at all, because it's already
going to be triggered by AccessibilityManager::UpdateSpokenFeedbackFromPref()
either way.

Kevin Chao and I manually tested with this patch and confirmed that this
fixes this specific issue and doesn't cause any new regressions.

BUG=669413
TESTED=Try various permutations of signing in and out with ChromeVox off and on
TBR=dtseng@chromium.org

Committed: https://crrev.com/a878ed97521d84503ccb0d7f77666d45bfd52fa9
Cr-Commit-Position: refs/heads/master@{#440261}

[dmazzoni, 2016-12-21 22:55:19]

Description was changed from

==========
Fix issue with signing in after ChromeVox was enabled in login screen

The call to AccessibilityExtensionLoader::SetProfile from
AccessibilityManager::SetProfile was causing a race condition that left
ChromeVox in a partially-loaded state, i.e. the extension was active but
AccessibilityManager thought it was not.

It turns out this call isn't necessary at all, because it's already
going to be triggered by AccessibilityManager::UpdateSpokenFeedbackFromPref()
either way.

Kevin Chao and I manually tested with this patch and confirmed that this
fixes this specific issue and doesn't cause any new regressions.

BUG=669413
TESTED=Try various permutations of signing in and out with ChromeVox off and on
==========

to

==========
Fix issue with signing in after ChromeVox was enabled in login screen

The call to AccessibilityExtensionLoader::SetProfile from
AccessibilityManager::SetProfile was causing a race condition that left
ChromeVox in a partially-loaded state, i.e. the extension was active but
AccessibilityManager thought it was not.

It turns out this call isn't necessary at all, because it's already
going to be triggered by AccessibilityManager::UpdateSpokenFeedbackFromPref()
either way.

Kevin Chao and I manually tested with this patch and confirmed that this
fixes this specific issue and doesn't cause any new regressions.

BUG=669413
TESTED=Try various permutations of signing in and out with ChromeVox off and on
TBR=dtseng@chromium.org
==========

[dmazzoni, 2016-12-21 22:55:19]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[dmazzoni, 2016-12-21 22:55:24]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-12-21 22:55:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2016-12-21 22:56:43]

Landing with TBR because Kevin and I tested it and
feel this is safe, and we'd like to get it into Canary
soon for further testing so we can decide whether to
merge when David is back and has a chance to review.

[commit-bot: I haz the power, 2016-12-21 23:31:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482360924787570, "parent_rev":
"2ced99fa2cf68b4a4525fa3cde0988b0b819ea37", "commit_rev":
"b2a72b9d049f14b7b4ed383335703736ea968ebc"}

[commit-bot: I haz the power, 2016-12-21 23:32:43]

Description was changed from

==========
Fix issue with signing in after ChromeVox was enabled in login screen

The call to AccessibilityExtensionLoader::SetProfile from
AccessibilityManager::SetProfile was causing a race condition that left
ChromeVox in a partially-loaded state, i.e. the extension was active but
AccessibilityManager thought it was not.

It turns out this call isn't necessary at all, because it's already
going to be triggered by AccessibilityManager::UpdateSpokenFeedbackFromPref()
either way.

Kevin Chao and I manually tested with this patch and confirmed that this
fixes this specific issue and doesn't cause any new regressions.

BUG=669413
TESTED=Try various permutations of signing in and out with ChromeVox off and on
TBR=dtseng@chromium.org
==========

to

==========
Fix issue with signing in after ChromeVox was enabled in login screen

The call to AccessibilityExtensionLoader::SetProfile from
AccessibilityManager::SetProfile was causing a race condition that left
ChromeVox in a partially-loaded state, i.e. the extension was active but
AccessibilityManager thought it was not.

It turns out this call isn't necessary at all, because it's already
going to be triggered by AccessibilityManager::UpdateSpokenFeedbackFromPref()
either way.

Kevin Chao and I manually tested with this patch and confirmed that this
fixes this specific issue and doesn't cause any new regressions.

BUG=669413
TESTED=Try various permutations of signing in and out with ChromeVox off and on
TBR=dtseng@chromium.org

Review-Url: https://codereview.chromium.org/2597793002
Committed:
https://chromium.googlesource.com/chromium/src/+/b2a72b9d049f14b7b4ed38333570...
==========

[commit-bot: I haz the power, 2016-12-21 23:32:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b2a72b9d049f14b7b4ed38333570...

[commit-bot: I haz the power, 2016-12-21 23:34:13]

Description was changed from

==========
Fix issue with signing in after ChromeVox was enabled in login screen

The call to AccessibilityExtensionLoader::SetProfile from
AccessibilityManager::SetProfile was causing a race condition that left
ChromeVox in a partially-loaded state, i.e. the extension was active but
AccessibilityManager thought it was not.

It turns out this call isn't necessary at all, because it's already
going to be triggered by AccessibilityManager::UpdateSpokenFeedbackFromPref()
either way.

Kevin Chao and I manually tested with this patch and confirmed that this
fixes this specific issue and doesn't cause any new regressions.

BUG=669413
TESTED=Try various permutations of signing in and out with ChromeVox off and on
TBR=dtseng@chromium.org

Review-Url: https://codereview.chromium.org/2597793002
Committed:
https://chromium.googlesource.com/chromium/src/+/b2a72b9d049f14b7b4ed38333570...
==========

to

==========
Fix issue with signing in after ChromeVox was enabled in login screen

The call to AccessibilityExtensionLoader::SetProfile from
AccessibilityManager::SetProfile was causing a race condition that left
ChromeVox in a partially-loaded state, i.e. the extension was active but
AccessibilityManager thought it was not.

It turns out this call isn't necessary at all, because it's already
going to be triggered by AccessibilityManager::UpdateSpokenFeedbackFromPref()
either way.

Kevin Chao and I manually tested with this patch and confirmed that this
fixes this specific issue and doesn't cause any new regressions.

BUG=669413
TESTED=Try various permutations of signing in and out with ChromeVox off and on
TBR=dtseng@chromium.org

Committed: https://crrev.com/a878ed97521d84503ccb0d7f77666d45bfd52fa9
Cr-Commit-Position: refs/heads/master@{#440261}
==========

[commit-bot: I haz the power, 2016-12-21 23:34:14]

Patchset 1 (id:??) landed as
https://crrev.com/a878ed97521d84503ccb0d7f77666d45bfd52fa9
Cr-Commit-Position: refs/heads/master@{#440261}