Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2597793002: Fix issue with signing in after ChromeVox was enabled in login screen (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 months ago by dmazzoni
Modified:
10 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix issue with signing in after ChromeVox was enabled in login screen The call to AccessibilityExtensionLoader::SetProfile from AccessibilityManager::SetProfile was causing a race condition that left ChromeVox in a partially-loaded state, i.e. the extension was active but AccessibilityManager thought it was not. It turns out this call isn't necessary at all, because it's already going to be triggered by AccessibilityManager::UpdateSpokenFeedbackFromPref() either way. Kevin Chao and I manually tested with this patch and confirmed that this fixes this specific issue and doesn't cause any new regressions. BUG=669413 TESTED=Try various permutations of signing in and out with ChromeVox off and on TBR=dtseng@chromium.org Committed: https://crrev.com/a878ed97521d84503ccb0d7f77666d45bfd52fa9 Cr-Commit-Position: refs/heads/master@{#440261}

Patch Set 1 #

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597793002/1
10 months ago (2016-12-21 22:55:45 UTC) #4
dmazzoni
Landing with TBR because Kevin and I tested it and feel this is safe, and ...
10 months ago (2016-12-21 22:56:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b2a72b9d049f14b7b4ed383335703736ea968ebc
10 months ago (2016-12-21 23:32:44 UTC) #8
commit-bot: I haz the power
10 months ago (2016-12-21 23:34:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a878ed97521d84503ccb0d7f77666d45bfd52fa9
Cr-Commit-Position: refs/heads/master@{#440261}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa