Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in

Issue 2597793002: Fix issue with signing in after ChromeVox was enabled in login screen (Closed)

Can't Edit
Can't Publish+Mail
Start Review
10 months ago by dmazzoni
10 months ago
David Tseng
chromium-reviews,,,,, je_julie,,,
Target Ref:


Fix issue with signing in after ChromeVox was enabled in login screen The call to AccessibilityExtensionLoader::SetProfile from AccessibilityManager::SetProfile was causing a race condition that left ChromeVox in a partially-loaded state, i.e. the extension was active but AccessibilityManager thought it was not. It turns out this call isn't necessary at all, because it's already going to be triggered by AccessibilityManager::UpdateSpokenFeedbackFromPref() either way. Kevin Chao and I manually tested with this patch and confirmed that this fixes this specific issue and doesn't cause any new regressions. BUG=669413 TESTED=Try various permutations of signing in and out with ChromeVox off and on Committed: Cr-Commit-Position: refs/heads/master@{#440261}

Patch Set 1 #


Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at
10 months ago (2016-12-21 22:55:45 UTC) #4
Landing with TBR because Kevin and I tested it and feel this is safe, and ...
10 months ago (2016-12-21 22:56:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as
10 months ago (2016-12-21 23:32:44 UTC) #8
commit-bot: I haz the power
10 months ago (2016-12-21 23:34:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
Cr-Commit-Position: refs/heads/master@{#440261}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa