Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2597763002:
Disable flaky test testFetchResourceLoadingError. (Closed)
DescriptionDisable flaky test testFetchResourceLoadingError.
TBR=sgurun@chromium.org
BUG=676422
Committed: https://crrev.com/b374ec6bd3e775e420e06ae34507529d6d164e31
Cr-Commit-Position: refs/heads/master@{#440252}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Add missing import #Messages
Total messages: 22 (16 generated)
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Disable flaky test testFetchResourceLoadingError. BUG=676422 ========== to ========== Disable flaky test testFetchResourceLoadingError. TBR=sgurun@chromium.org BUG=676422 ==========
The CQ bit was unchecked by hcarmona@chromium.org
The CQ bit was checked by hcarmona@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
boliu@chromium.org changed reviewers: + boliu@chromium.org
lgtm https://codereview.chromium.org/2597763002/diff/1/android_webview/javatests/s... File android_webview/javatests/src/org/chromium/android_webview/test/AwServiceWorkerClientTest.java (right): https://codereview.chromium.org/2597763002/diff/1/android_webview/javatests/s... android_webview/javatests/src/org/chromium/android_webview/test/AwServiceWorkerClientTest.java:85: public void testFetchHttpError() throws Throwable { might want to get this one as well, for crbug.com/676437
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hcarmona@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org Link to the patchset: https://codereview.chromium.org/2597763002/#ps20001 (title: "Add missing import")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482360556156720,
"parent_rev": "140d9743ef27f025a8ca0ca305a0751c629f4380", "commit_rev":
"7b73b9bbf318336f2bb2df0d366805781c239362"}
Message was sent while issue was closed.
Description was changed from ========== Disable flaky test testFetchResourceLoadingError. TBR=sgurun@chromium.org BUG=676422 ========== to ========== Disable flaky test testFetchResourceLoadingError. TBR=sgurun@chromium.org BUG=676422 Review-Url: https://codereview.chromium.org/2597763002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Disable flaky test testFetchResourceLoadingError. TBR=sgurun@chromium.org BUG=676422 Review-Url: https://codereview.chromium.org/2597763002 ========== to ========== Disable flaky test testFetchResourceLoadingError. TBR=sgurun@chromium.org BUG=676422 Committed: https://crrev.com/b374ec6bd3e775e420e06ae34507529d6d164e31 Cr-Commit-Position: refs/heads/master@{#440252} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b374ec6bd3e775e420e06ae34507529d6d164e31 Cr-Commit-Position: refs/heads/master@{#440252} |
