[ic] Remove deprecated LoadConstantStub and other related dead code

[ic] Remove deprecated LoadConstantStub and other related dead code

Review-Url: https://codereview.chromium.org/2597693002
Cr-Commit-Position: refs/heads/master@{#41903}
Committed: https://chromium.googlesource.com/v8/v8/+/bad367fd9d7ee01029c99f40e54eaa199210a578

[danno, 2016-12-21 16:43:23]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 16:43:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2016-12-21 16:43:44]

Description was changed from

==========
[ics] Remove deprecated LoadConstantStub and other dead code
==========

to

==========
[ics] Remove deprecated LoadConstantStub and other related dead code
==========

[danno, 2016-12-21 16:43:44]

danno@chromium.org changed reviewers:
+ ishell@chromium.org

[danno, 2016-12-21 16:44:36]

danno@chromium.org changed reviewers:
+ jkummerow@chromium.org

[danno, 2016-12-21 16:44:37]

PTAL

[Igor Sheludko, 2016-12-21 16:51:00]

Description was changed from

==========
[ics] Remove deprecated LoadConstantStub and other related dead code
==========

to

==========
[ic] Remove deprecated LoadConstantStub and other related dead code
==========

[Igor Sheludko, 2016-12-21 16:51:13]

lgtm with nits:

https://codereview.chromium.org/2597693002/diff/1/src/ic/handler-compiler.cc
File src/ic/handler-compiler.cc (left):

https://codereview.chromium.org/2597693002/diff/1/src/ic/handler-compiler.cc#...
src/ic/handler-compiler.cc:515: StoreMapStub stub(isolate());
This stub is also a dead code.

https://codereview.chromium.org/2597693002/diff/1/src/ic/handler-compiler.cc#...
src/ic/handler-compiler.cc:540: StoreTransitionStub stub(isolate(),
index.is_inobject(), representation,
Same here.

https://codereview.chromium.org/2597693002/diff/1/src/ic/handler-compiler.cc#...
src/ic/handler-compiler.cc:577: StoreFieldStub stub(isolate(),
it->GetFieldIndex(), it->representation());
Same here.

[danno, 2016-12-21 16:59:11]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 16:59:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2016-12-21 16:59:28]

Feedback addressed, landing

https://codereview.chromium.org/2597693002/diff/1/src/ic/handler-compiler.cc
File src/ic/handler-compiler.cc (left):

https://codereview.chromium.org/2597693002/diff/1/src/ic/handler-compiler.cc#...
src/ic/handler-compiler.cc:515: StoreMapStub stub(isolate());
On 2016/12/21 16:51:13, Igor Sheludko wrote:
> This stub is also a dead code.

Done.

https://codereview.chromium.org/2597693002/diff/1/src/ic/handler-compiler.cc#...
src/ic/handler-compiler.cc:540: StoreTransitionStub stub(isolate(),
index.is_inobject(), representation,
On 2016/12/21 16:51:13, Igor Sheludko wrote:
> Same here.

Done.

https://codereview.chromium.org/2597693002/diff/1/src/ic/handler-compiler.cc#...
src/ic/handler-compiler.cc:577: StoreFieldStub stub(isolate(),
it->GetFieldIndex(), it->representation());
On 2016/12/21 16:51:13, Igor Sheludko wrote:
> Same here.

Done.

[commit-bot: I haz the power, 2016-12-21 17:27:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 17:27:58]

Dry run: This issue passed the CQ dry run.

[danno, 2016-12-21 20:11:59]

The CQ bit was checked by danno@chromium.org

[danno, 2016-12-21 20:11:59]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2597693002/#ps20001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-12-21 20:12:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 20:14:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482351119417940,
"parent_rev": "2041c504025d706041e50e52d9e8c7221667492d", "commit_rev":
"bad367fd9d7ee01029c99f40e54eaa199210a578"}

[commit-bot: I haz the power, 2016-12-21 20:14:08]

Description was changed from

==========
[ic] Remove deprecated LoadConstantStub and other related dead code
==========

to

==========
[ic] Remove deprecated LoadConstantStub and other related dead code

Review-Url: https://codereview.chromium.org/2597693002
Cr-Commit-Position: refs/heads/master@{#41903}
Committed:
https://chromium.googlesource.com/v8/v8/+/bad367fd9d7ee01029c99f40e54eaa19921...
==========

[commit-bot: I haz the power, 2016-12-21 20:14:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/bad367fd9d7ee01029c99f40e54eaa19921...