[Remote suggestions] Interface for additional triggers for the scheduler

[Remote suggestions] Interface for additional triggers for the scheduler

This CL adds new methods to call on additional fetching triggers. The
actual triggers and fetching will be implemented in later CLs.

BUG=672479
Committed: https://crrev.com/d28961791eb33b87e6bce4c092bd287bd932eb0e
Cr-Commit-Position: refs/heads/master@{#440133}

[jkrcal, 2016-12-21 14:17:26]

jkrcal@chromium.org changed reviewers:
+ tschumann@chromium.org

[jkrcal, 2016-12-21 14:17:26]

Tim, could you PTAL? 

This allows us to divide work between me and Friedrich.

[jkrcal, 2016-12-21 14:26:20]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 14:26:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tschumann, 2016-12-21 14:27:37]

lgtm

https://codereview.chromium.org/2597653002/diff/1/components/ntp_snippets/rem...
File components/ntp_snippets/remote/remote_suggestions_scheduler.h (right):

https://codereview.chromium.org/2597653002/diff/1/components/ntp_snippets/rem...
components/ntp_snippets/remote/remote_suggestions_scheduler.h:17: virtual bool
OnBrowserStartup() = 0;
is the return value actually of interest?
the caller just provides the signal, why would it care about the action the
scheduler chose?

[jkrcal, 2016-12-21 14:34:56]

The CQ bit was checked by jkrcal@chromium.org

[jkrcal, 2016-12-21 14:34:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
tschumann@chromium.org
Link to the patchset: https://codereview.chromium.org/2597653002/#ps20001
(title: "Fixing the return type.")

[commit-bot: I haz the power, 2016-12-21 14:35:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 14:35:18]

This CL has an open dependency (Issue 2557363002 Patch 400001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[jkrcal, 2016-12-21 14:35:21]

https://codereview.chromium.org/2597653002/diff/1/components/ntp_snippets/rem...
File components/ntp_snippets/remote/remote_suggestions_scheduler.h (right):

https://codereview.chromium.org/2597653002/diff/1/components/ntp_snippets/rem...
components/ntp_snippets/remote/remote_suggestions_scheduler.h:17: virtual bool
OnBrowserStartup() = 0;
On 2016/12/21 14:27:37, tschumann wrote:
> is the return value actually of interest?
> the caller just provides the signal, why would it care about the action the
> scheduler chose?

Ah, you are right. I wanted to implement some histogram on the outside based on
the return value but it is actually better to do it inside the scheduler.

[jkrcal, 2016-12-21 14:35:52]

The CQ bit was checked by jkrcal@chromium.org

[commit-bot: I haz the power, 2016-12-21 14:36:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 14:36:12]

This CL has an open dependency (Issue 2557363002 Patch 400001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[jkrcal, 2016-12-21 14:58:41]

The CQ bit was checked by jkrcal@chromium.org

[commit-bot: I haz the power, 2016-12-21 14:58:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 14:58:55]

This CL has an open dependency (Issue 2557363002 Patch 400001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[fhorschig, 2016-12-21 16:19:37]

The CQ bit was checked by fhorschig@chromium.org

[commit-bot: I haz the power, 2016-12-21 16:19:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 17:12:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482337177546110,
"parent_rev": "9fa84b13c823fe85bce024e0c5b874bcfd4c3d15", "commit_rev":
"95c812ef9ca47230927a85b7110d68d24619fbcb"}

[commit-bot: I haz the power, 2016-12-21 17:12:44]

Description was changed from

==========
[Remote suggestions] Interface for additional triggers for the scheduler

This CL adds new methods to call on additional fetching triggers. The
actual triggers and fetching will be implemented in later CLs.

BUG=672479
==========

to

==========
[Remote suggestions] Interface for additional triggers for the scheduler

This CL adds new methods to call on additional fetching triggers. The
actual triggers and fetching will be implemented in later CLs.

BUG=672479

Review-Url: https://codereview.chromium.org/2597653002
==========

[commit-bot: I haz the power, 2016-12-21 17:12:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-21 17:14:18]

Description was changed from

==========
[Remote suggestions] Interface for additional triggers for the scheduler

This CL adds new methods to call on additional fetching triggers. The
actual triggers and fetching will be implemented in later CLs.

BUG=672479

Review-Url: https://codereview.chromium.org/2597653002
==========

to

==========
[Remote suggestions] Interface for additional triggers for the scheduler

This CL adds new methods to call on additional fetching triggers. The
actual triggers and fetching will be implemented in later CLs.

BUG=672479

Committed: https://crrev.com/d28961791eb33b87e6bce4c092bd287bd932eb0e
Cr-Commit-Position: refs/heads/master@{#440133}
==========

[commit-bot: I haz the power, 2016-12-21 17:14:19]

Patchset 2 (id:??) landed as
https://crrev.com/d28961791eb33b87e6bce4c092bd287bd932eb0e
Cr-Commit-Position: refs/heads/master@{#440133}