Even empty block intervals should be associated with a fragmentainer.

Even empty block intervals should be associated with a fragmentainer.

We need to visit the fragmentainer that a block lives in even if said block has
zero height. If we find a column set, don't perform initial bounds checking.

BUG=675943
Committed: https://crrev.com/f84a9dc354e51ae5353f9cb580574496f9184822
Cr-Commit-Position: refs/heads/master@{#440361}

[mstensho (USE GERRIT), 2016-12-21 09:11:08]

The CQ bit was checked by mstensho@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 09:11:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 10:48:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 10:48:50]

Dry run: This issue passed the CQ dry run.

[mstensho (USE GERRIT), 2016-12-21 10:50:28]

mstensho@opera.com changed reviewers:
+ eae@chromium.org, szager@chromium.org

[szager1, 2016-12-21 23:47:11]

lgtm w/nits

https://codereview.chromium.org/2597633002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/multicol/client-rects-sole-empty-block.html
(right):

https://codereview.chromium.org/2597633002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/multicol/client-rects-sole-empty-block.html:13:
assert_equals(rects[0].top, 100);
Why is 'top' not 108?

https://codereview.chromium.org/2597633002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp (right):

https://codereview.chromium.org/2597633002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp:32: // Jump to
the first interesting column set.
This comment seems obsolete.

[mstensho (USE GERRIT), 2016-12-22 08:10:26]

https://codereview.chromium.org/2597633002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/multicol/client-rects-sole-empty-block.html
(right):

https://codereview.chromium.org/2597633002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/multicol/client-rects-sole-empty-block.html:13:
assert_equals(rects[0].top, 100);
On 2016/12/21 23:47:11, szager1 wrote:
> Why is 'top' not 108?

Margin collapsing between body and the outer div.

https://codereview.chromium.org/2597633002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp (right):

https://codereview.chromium.org/2597633002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp:32: // Jump to
the first interesting column set.
On 2016/12/21 23:47:11, szager1 wrote:
> This comment seems obsolete.

Not really. We're still picking a column set based on the flow thread range
start.

[mstensho (USE GERRIT), 2016-12-22 08:10:31]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-12-22 08:10:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 08:16:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482394231798310, "parent_rev":
"80cd19eda236ff9e95e90b72cbafd118a4ad2a95", "commit_rev":
"7bc0ba5ac76ccac93a3c79afa7bd6ae263ea1075"}

[commit-bot: I haz the power, 2016-12-22 08:17:07]

Description was changed from

==========
Even empty block intervals should be associated with a fragmentainer.

We need to visit the fragmentainer that a block lives in even if said block has
zero height. If we find a column set, don't perform initial bounds checking.

BUG=675943
==========

to

==========
Even empty block intervals should be associated with a fragmentainer.

We need to visit the fragmentainer that a block lives in even if said block has
zero height. If we find a column set, don't perform initial bounds checking.

BUG=675943

Review-Url: https://codereview.chromium.org/2597633002
==========

[commit-bot: I haz the power, 2016-12-22 08:17:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-22 08:18:56]

Description was changed from

==========
Even empty block intervals should be associated with a fragmentainer.

We need to visit the fragmentainer that a block lives in even if said block has
zero height. If we find a column set, don't perform initial bounds checking.

BUG=675943

Review-Url: https://codereview.chromium.org/2597633002
==========

to

==========
Even empty block intervals should be associated with a fragmentainer.

We need to visit the fragmentainer that a block lives in even if said block has
zero height. If we find a column set, don't perform initial bounds checking.

BUG=675943

Committed: https://crrev.com/f84a9dc354e51ae5353f9cb580574496f9184822
Cr-Commit-Position: refs/heads/master@{#440361}
==========

[commit-bot: I haz the power, 2016-12-22 08:18:57]

Patchset 1 (id:??) landed as
https://crrev.com/f84a9dc354e51ae5353f9cb580574496f9184822
Cr-Commit-Position: refs/heads/master@{#440361}