Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2597573002: MD History/Downloads: convert .bind(this) and function property values to use => (Closed)

Created:
4 years ago by Dan Beam
Modified:
3 years, 8 months ago
Reviewers:
CC:
arv+watch_chromium.org, asanka, chromium-reviews, dbeam+watch-history_chromium.org, dbeam+watch-downloads_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, pam+watch_chromium.org, michaelpg
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History/Downloads: convert .bind(this) and function property values to use => R= BUG=671426 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Total comments: 3

Messages

Total messages: 6 (3 generated)
dpapad
https://codereview.chromium.org/2597573002/diff/1/chrome/browser/resources/md_history/synced_device_card.js File chrome/browser/resources/md_history/synced_device_card.js (right): https://codereview.chromium.org/2597573002/diff/1/chrome/browser/resources/md_history/synced_device_card.js#newcode21 chrome/browser/resources/md_history/synced_device_card.js:21: value: () => [], Can we use arrow only ...
4 years ago (2016-12-21 23:49:53 UTC) #2
michaelpg
https://codereview.chromium.org/2597573002/diff/1/chrome/browser/resources/md_history/synced_device_card.js File chrome/browser/resources/md_history/synced_device_card.js (right): https://codereview.chromium.org/2597573002/diff/1/chrome/browser/resources/md_history/synced_device_card.js#newcode21 chrome/browser/resources/md_history/synced_device_card.js:21: value: () => [], On 2016/12/21 23:49:53, dpapad wrote: ...
4 years ago (2016-12-22 07:35:19 UTC) #5
Dan Beam
4 years ago (2016-12-22 18:33:17 UTC) #6
https://codereview.chromium.org/2597573002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/2597573002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/synced_device_card.js:21: value: () => [],
On 2016/12/22 07:35:19, michaelpg (OOO) wrote:
> On 2016/12/21 23:49:53, dpapad wrote:
> > Can we use arrow only when:
> >  1) Used inside a member function.
> 
> why?
> 
> >  2) we previously we used bind()
> 
> why?? (why limit it to that?)
> 
> >  
> > for now? I am leaning towards considering non-bound functions more readable
> with
> > the old syntax.
> 

well, I obviously agreed with ... myself when I made this change, but my
understanding of what dpapad@ is saying is that: => shines most when we're able
to drop .bind(this).  nobody's arguing against that, afaik.

Powered by Google App Engine
This is Rietveld 408576698