MD History/Downloads: convert .bind(this) and function property values to use =>

MD History/Downloads: convert .bind(this) and function property values to use =>

R=
BUG=671426
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

[Dan Beam, 2016-12-21 03:56:56]

Description was changed from

==========
MD History/Downloads: convert .bind(this) and function property values to use =>

R=dpapad@chromium.org
BUG=671426
==========

to

==========
MD History/Downloads: convert .bind(this) and function property values to use =>

R=dpapad@chromium.org
BUG=671426
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-12-21 23:49:53]

https://codereview.chromium.org/2597573002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/2597573002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/synced_device_card.js:21: value: () => [],
Can we use arrow only when:
 1) Used inside a member function.
 2) we previously we used bind()
 
for now? I am leaning towards considering non-bound functions more readable with
the old syntax.

[Dan Beam, 2016-12-22 00:09:42]

Description was changed from

==========
MD History/Downloads: convert .bind(this) and function property values to use =>

R=dpapad@chromium.org
BUG=671426
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History/Downloads: convert .bind(this) and function property values to use =>

R=
BUG=671426
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-12-22 00:09:42]

dbeam@chromium.org changed reviewers:
- dpapad@chromium.org

[michaelpg, 2016-12-22 07:35:19]

https://codereview.chromium.org/2597573002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/2597573002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/synced_device_card.js:21: value: () => [],
On 2016/12/21 23:49:53, dpapad wrote:
> Can we use arrow only when:
>  1) Used inside a member function.

why?

>  2) we previously we used bind()

why?? (why limit it to that?)

>  
> for now? I am leaning towards considering non-bound functions more readable
with
> the old syntax.

[Dan Beam, 2016-12-22 18:33:17]

https://codereview.chromium.org/2597573002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/2597573002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/synced_device_card.js:21: value: () => [],
On 2016/12/22 07:35:19, michaelpg (OOO) wrote:
> On 2016/12/21 23:49:53, dpapad wrote:
> > Can we use arrow only when:
> >  1) Used inside a member function.
> 
> why?
> 
> >  2) we previously we used bind()
> 
> why?? (why limit it to that?)
> 
> >  
> > for now? I am leaning towards considering non-bound functions more readable
> with
> > the old syntax.
> 

well, I obviously agreed with ... myself when I made this change, but my
understanding of what dpapad@ is saying is that: => shines most when we're able
to drop .bind(this).  nobody's arguing against that, afaik.