Chromium Code Reviews
DescriptionRevert of Move ResourceHandler deferred actions ahead of external protocol handling. (patchset #3 id:40001 of https://codereview.chromium.org/2574063003/ )
Reason for revert:
This patch made two layout tests TIMEOUT:
virtual/mojo-loading/http/tests/misc/redirect-to-about-blank.html
http/tests/misc/redirect-to-about-blank.html
Original issue's description:
> Move ResourceHandler deferred actions ahead of external protocol handling.
>
> While working on moving mixed-content checks to the browser
> (https://codereview.chromium.org/1905033002) I found out that external protocol
> handling happened too early in the processing of request start and redirects
> done by ResourceLoader; namely before ResourceHandler implementations are
> notified and able to do their work in deferred tasks.
>
> This CL changes that order to allow the upcoming mixed-content
> NavigationThrottle implementation to properly check the navigation start or
> redirect ahead of external protocol dispatching.
>
> For the record, the failing layout test that brought this change to light was:
> http/tests/security/mixedContent/nonwebby-scheme-in-iframe-allowed.https.html
>
> BUG=576270
>
> Committed: https://crrev.com/94bd59f28dcf81289f09c39d189128254631b275
> Cr-Commit-Position: refs/heads/master@{#439923}
TBR=jam@chromium.org,mmenke@chromium.org,carlosk@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=576270
Committed: https://crrev.com/1a7071bf34b7ee2375432347b4bda11ab1fed835
Cr-Commit-Position: refs/heads/master@{#439957}
Patch Set 1 #
Messages
Total messages: 8 (4 generated)
|
|||||||||||||||||||||||||||||||||||||