Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2597563002: Revert of Move ResourceHandler deferred actions ahead of external protocol handling. (Closed)

Created:
4 years ago by shimazu
Modified:
4 years ago
Reviewers:
jam, carlosk, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, jam, Randy Smith (Not in Mondays), darin-cc_chromium.org, loading-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move ResourceHandler deferred actions ahead of external protocol handling. (patchset #3 id:40001 of https://codereview.chromium.org/2574063003/ ) Reason for revert: This patch made two layout tests TIMEOUT: virtual/mojo-loading/http/tests/misc/redirect-to-about-blank.html http/tests/misc/redirect-to-about-blank.html Original issue's description: > Move ResourceHandler deferred actions ahead of external protocol handling. > > While working on moving mixed-content checks to the browser > (https://codereview.chromium.org/1905033002) I found out that external protocol > handling happened too early in the processing of request start and redirects > done by ResourceLoader; namely before ResourceHandler implementations are > notified and able to do their work in deferred tasks. > > This CL changes that order to allow the upcoming mixed-content > NavigationThrottle implementation to properly check the navigation start or > redirect ahead of external protocol dispatching. > > For the record, the failing layout test that brought this change to light was: > http/tests/security/mixedContent/nonwebby-scheme-in-iframe-allowed.https.html > > BUG=576270 > > Committed: https://crrev.com/94bd59f28dcf81289f09c39d189128254631b275 > Cr-Commit-Position: refs/heads/master@{#439923} TBR=jam@chromium.org,mmenke@chromium.org,carlosk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=576270 Committed: https://crrev.com/1a7071bf34b7ee2375432347b4bda11ab1fed835 Cr-Commit-Position: refs/heads/master@{#439957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -171 lines) Patch
M content/browser/loader/resource_loader.h View 3 chunks +0 lines, -5 lines 0 comments Download
M content/browser/loader/resource_loader.cc View 6 chunks +12 lines, -25 lines 0 comments Download
M content/browser/loader/resource_loader_unittest.cc View 20 chunks +2 lines, -141 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
shimazu
Created Revert of Move ResourceHandler deferred actions ahead of external protocol handling.
4 years ago (2016-12-21 00:47:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597563002/1
4 years ago (2016-12-21 00:48:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 00:50:02 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-21 00:53:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a7071bf34b7ee2375432347b4bda11ab1fed835
Cr-Commit-Position: refs/heads/master@{#439957}

Powered by Google App Engine
This is Rietveld 408576698