Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2007)

Issue 2597513002: Supply video_decode_accelerator_unittest args in buildbot json (Closed)

Created:
4 years ago by jbauman
Modified:
4 years ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Supply video_decode_accelerator_unittest args in buildbot json Some GPU FYI machines don't use isolates, so we need to specify the arguments to video_decode_accelerator_unittest in the buildbot json instead. BUG=676053 TBR=kbr@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/14c2d14e20ae335e22dc9873a700c1ec48dff53d Cr-Commit-Position: refs/heads/master@{#439943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
M content/test/gpu/generate_buildbot_json.py View 1 chunk +4 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.gpu.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 15 chunks +45 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597513002/1
4 years ago (2016-12-20 21:44:28 UTC) #3
Ken Russell (switch to Gerrit)
LGTM This looks good. I don't know how long the webgl2 conformance tests on ATI ...
4 years ago (2016-12-20 23:42:01 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/6165)
4 years ago (2016-12-20 23:48:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597513002/1
4 years ago (2016-12-20 23:59:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 00:08:14 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-21 00:11:43 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14c2d14e20ae335e22dc9873a700c1ec48dff53d
Cr-Commit-Position: refs/heads/master@{#439943}

Powered by Google App Engine
This is Rietveld 408576698