Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 2597453002: devtools: Fix crash when WebContents is deleted by a message handler (Closed)

Created:
4 years ago by Sami
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

devtools: Fix crash when WebContents is deleted by a message handler If a DevTools message handler deletes the WebContents which originated the message, we previously tried to access a member of an already-freed FrameHostHolder. TEST=headless_browsertests --gtest_filter=HeadlessBrowserContextIsolationTest.RunAsyncTest Committed: https://crrev.com/2ce98a25d03dadf0434e885fc36dd976ea7d7519 Cr-Commit-Position: refs/heads/master@{#439879}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Sami
4 years ago (2016-12-20 17:48:17 UTC) #4
Sami
+jam@ FYI, I think this one snuck in via https://codereview.chromium.org/2585053002.
4 years ago (2016-12-20 18:05:01 UTC) #6
dgozman
lgtm, thanks for the fix.
4 years ago (2016-12-20 18:35:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597453002/1
4 years ago (2016-12-20 18:42:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 20:25:06 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-20 20:29:11 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ce98a25d03dadf0434e885fc36dd976ea7d7519
Cr-Commit-Position: refs/heads/master@{#439879}

Powered by Google App Engine
This is Rietveld 408576698