Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2597443002: Roll ANGLE f047097..71168a0 (Closed)

Created:
4 years ago by Jamie Madill
Modified:
4 years ago
Reviewers:
Corentin Wallez
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll ANGLE f047097..71168a0 https://chromium.googlesource.com/angle/angle.git/+log/f047097..71168a0 BUG=chromium:674143 TBR=cwallez@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/47cd7960532e2a1bd4e7a987b69c66f632f7f6c9 Cr-Commit-Position: refs/heads/master@{#439866}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597443002/1
4 years ago (2016-12-20 17:46:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 19:12:51 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/47cd7960532e2a1bd4e7a987b69c66f632f7f6c9 Cr-Commit-Position: refs/heads/master@{#439866}
4 years ago (2016-12-20 19:14:51 UTC) #8
jam
4 years ago (2016-12-20 20:11:30 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2587413003/ by jam@chromium.org.

The reason for reverting is:
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/6994/steps/co...

ninja -t msvc -e environment.x64 -- C:\b\c\cipd\goma/gomacc.exe
"C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64/cl.exe"
/nologo /showIncludes /FC
@obj/third_party/angle/src/tests/angle_perftests/UniformsPerf.obj.rsp /c
../../third_party/angle/src/tests/perf_tests/UniformsPerf.cpp
/Foobj/third_party/angle/src/tests/angle_perftests/UniformsPerf.obj
/Fd"obj/third_party/angle/src/tests/angle_perftests_cc.pdb"
c:\b\c\b\win_x64_archive\src\third_party\angle\src\tests\perf_tests\uniformsperf.cpp(148):
error C2220: warning treated as error - no 'object' file generated
c:\b\c\b\win_x64_archive\src\third_party\angle\src\tests\perf_tests\uniformsperf.cpp(148):
warning C4267: 'initializing': conversion from 'size_t' to 'GLint', possible
loss of data
c:\b\c\b\win_x64_archive\src\third_party\angle\src\tests\perf_tests\uniformsperf.cpp(149):
warning C4267: 'initializing': conversion from 'size_t' to 'GLint', possible
loss of data.

Powered by Google App Engine
This is Rietveld 408576698