Issue 259743003: Integrate fix for issue 18452 on the 1.3 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 259743003: Integrate fix for issue 18452 on the 1.3 branch. (Closed)

Created:
6 years, 7 months ago by ricow1

Modified:
6 years, 6 months ago

Reviewers:
zra, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/1.3/

Visibility:
Public.

Integrate fix for issue 18452 on the 1.3 branch. This is effectively merging revision r35524 from bleeding edge to 1.3 branch

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -3 lines)			Patch
M	dart/runtime/vm/assembler_x64.cc	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	dart/runtime/vm/stub_code.h	View	2 chunks	+1 line, -1 line	0 comments	Download
A +	dart/tests/standalone/io/directory_list_sync_test.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 5 (0 generated)

Ivan Posva

6 years, 6 months ago (2014-06-09 20:50:02 UTC) #5

On 2014/06/05 23:45:07, Ivan Posva wrote:
> Is this still an active review?
> 
> -Ivan

Closing. -ip