Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2597413002: Makes the InputMethodEngine can be switched per profile when the top-level browser window is switch… (Closed)

Created:
3 years, 12 months ago by Shu Chen
Modified:
3 years, 12 months ago
Reviewers:
Azure Wei
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes the InputMethodEngine can be switched per profile when the top-level browser window is switched. BUG=655435 Committed: https://crrev.com/2e264372929e2a983205b972a06a517ac25a1685 Cr-Commit-Position: refs/heads/master@{#440602}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M chrome/browser/chromeos/input_method/input_method_engine_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_engine.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_engine.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/input_method/input_method_engine_base.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/input_method/input_method_engine_base.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/input_method/input_method_engine_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ime/chromeos/mock_ime_engine_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ime/chromeos/mock_ime_engine_handler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/ime/ime_engine_handler_interface.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/base/ime/input_method_base.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
Shu Chen
Please review this cl, thanks!
3 years, 12 months ago (2016-12-23 03:23:44 UTC) #4
Azure Wei
lgtm
3 years, 12 months ago (2016-12-23 06:43:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597413002/20001
3 years, 12 months ago (2016-12-23 07:42:44 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 12 months ago (2016-12-23 08:39:54 UTC) #13
commit-bot: I haz the power
3 years, 12 months ago (2016-12-23 08:42:20 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2e264372929e2a983205b972a06a517ac25a1685
Cr-Commit-Position: refs/heads/master@{#440602}

Powered by Google App Engine
This is Rietveld 408576698