Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 2597403002: Disable flaky test OmniboxViewViewsTest.SelectionClipboard (Closed)

Created:
4 years ago by Dan Beam
Modified:
3 years, 12 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky test OmniboxViewViewsTest.SelectionClipboard TBR=msw@chromium.org BUG=676746 Committed: https://crrev.com/dea296de1bb5b61515994926d3ece3165274ffc2 Cr-Commit-Position: refs/heads/master@{#440586}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Dan Beam
4 years ago (2016-12-23 02:11:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597403002/1
4 years ago (2016-12-23 02:11:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-23 02:47:22 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dea296de1bb5b61515994926d3ece3165274ffc2 Cr-Commit-Position: refs/heads/master@{#440586}
4 years ago (2016-12-23 02:49:24 UTC) #8
msw
It seems this just started flaking today; is there any consistency in the failure logs? ...
4 years ago (2016-12-23 04:06:54 UTC) #9
Dan Beam
3 years, 12 months ago (2016-12-26 00:44:29 UTC) #10
Message was sent while issue was closed.
On 2016/12/23 04:06:54, msw wrote:
> It seems this just started flaking today; is there any consistency in the
> failure logs? Have you found any recent changes that might have introduced
> flakiness here? In general, clipboard tests should be okay as
> interactive_ui_tests.

i looked briefly at the logs but didn't see a smoking gun.  I mainly saw that it
was blocking CQs and that the bug filed by some sheriff bot said to revert it in
like 30m (and it has been flaking for 10-20m)

Powered by Google App Engine
This is Rietveld 408576698